When visiting admin/reports/analytics, it appears that the "Statuses Shared" graph is producing a SQL error. See the attached screenshot for the error and a dsm() of the $quant object passed to quant_execute_query() which is producing the error. I expanded the $quant->query property, and you will see that the $quant->table object is empty. This issue is reported against the RC1 release of Commons.

CommentFileSizeAuthor
#1 quant-fixing-fbss-integration-1269460.patch458 bytesicecreamyou
quant-sql-error.jpg175.4 KBcpliakas

Comments

icecreamyou’s picture

icecreamyou commented
Status: Active » Needs review
StatusFileSize
new quant-fixing-fbss-integration-1269460.patch458 bytes

I think Quant is supposed to use the ID as the table name if no table name exists?

Anyway, the obvious solution should be to change quants.inc line 191 to $quant->table = 'facebook_status';

Patch attached.

mstef’s picture

mstef commented
Status: Needs review » Fixed

How in the world did I make that mistake..?

Fixed - thanks.

ezra-g’s picture

ezra-g commented
Status: Fixed » Reviewed & tested by the community

I'm setting this back to RTBC so that we can [edit] commit it when we move to packaging with Drush make.

@Mike, I don't see this at https://github.com/acquia/commons/commits/master, but that's OK as we'll be moving to Drush make relatively soon.

mstef’s picture

mstef commented

I thought this was the Quant queue. My mistake. It's been committed to the project, so you can just pull the latest.

ezra-g’s picture

ezra-g commented
Status: Reviewed & tested by the community » Fixed

Marking as fixed per #4.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

jlea9378’s picture

jlea9378 commented
Version: » 6.x-2.6
Status: Closed (fixed) » Reviewed & tested by the community

I just upgraded my site to Commons 2.6 from Commons 2.5 and this patch wasn't applied to the Quant module. I implemented the change in the patch and the error I was seeing on the Site Analytics page went away. Will this fix be included in Commons 2.7??

icecreamyou’s picture

icecreamyou commented

The patch is correctly committed to Quant, but it looks like drupal-commons.make specifically references the commit of Quant immediately before the patch was applied.

ezra-g’s picture

ezra-g commented
Issue tags: +Commons 2.7 radar

Thanks, IceCreamYou. Tagging for 2.7.

ezra-g’s picture

ezra-g commented
Status: Reviewed & tested by the community » Fixed

I've updated the Commons make file to pull from the Quant 6.x-1.x dev branch.

http://drupalcode.org/project/commons.git/commit/03d2e1e

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

Fixed grammar.