Once a day, I get a requirement error, right after the update cache has expired. The workaround from version 6 does not prevent this temporary situation anymore, due to changes in the core update module.

The attached patch should fix this.

CommentFileSizeAuthor
#1 update_check_pending2.diff1.13 KBmorenstrat
update_check_pending.diff1.1 KBmorenstrat

Comments

morenstrat’s picture

morenstrat
he/him
Primary language German
Location Bochum, Germany
commented
StatusFileSize
new update_check_pending2.diff1.13 KB

Something else changed in the update module. The requirement key can also be 'update_contrib'. I attached a slightly revised patch.

greg.harvey’s picture

greg.harvey
Primary language English
Location Occitanie, France
commented
Status: Active » Needs review

Thanks, will review and include once we take a run at the D7 version, which will be very soon. =)

greg.harvey’s picture

greg.harvey
Primary language English
Location Occitanie, France
commented
Status: Needs review » Needs work

I believe your patch still needs to include the change to nagios-plugin/check_drupal included in #832288: return unknown rather than critical on wget failure - include that and we can commit to dev.

Edit: or am I totally misunderstanding this? Where's the D6 fix you refer to?

morenstrat’s picture

morenstrat
he/him
Primary language German
Location Bochum, Germany
commented

I was referring to issue #615128: warning issued when update status check fails, which is fixed. So nothing needs to be done for the D6 version. What I meant was that the D7 port was not correct and that my patch should fix it. Oh, and this has nothing to do with the nagios plug-in.

greg.harvey’s picture

greg.harvey
Primary language English
Location Occitanie, France
commented
Status: Needs work » Closed (duplicate)

Ahh, OK, moving the discussion there - re-opened and attached your patch. Marking this as a dupe.