Hi, I needed the views support for similarterms in d7 so I took a stab at upgrading the 6.x-2.x branch to d7. It wasn't that difficult actually, and the code came out a little cleaner than the 6.x-2.x branch.

Could you create a 7.x-2.x branch on Drupal.org for this work? Currently everything is hosted on GitHub at https://github.com/jamesandres/similarterms.

PS: It's a longer term point, but I recommend dropping the 7.x-1.x branch entirely. In my opinion it is less useful than similarterms running on views and will likely cause confusion for new users.

Thanks,

James

CommentFileSizeAuthor
#15 1270244-15.patch36.08 KBBrockBoland
#14 1270244-port.patch85.21 KBdawehner
#13 1270244-port.patch21.6 KBdawehner
#12 similarterms-7x-2x-default-view-1270244-12.patch13.64 KBjordojuice
#7 argument_saving_bug-1270244.patch1.58 KBCasper_Deseyne
#6 argument_saving_bug-1270244.patch564 bytesCasper_Deseyne
#3 argument_handler_bug-1270244.patch564 bytestheunraveler

Comments

rmiddle’s picture

rmiddle commented

7.x-1.x isn't going anywhere for now. Not everyone use views. As for 7.x-2.x I will create a branch for it and look at the code in git code.

Thanks
Robert

James Andres’s picture

James Andres commented

Thanks for having a look Robert. Of course, the choice to maintain two branches is totally up to you! :)

theunraveler’s picture

theunraveler commented
StatusFileSize
new argument_handler_bug-1270244.patch564 bytes

I'm not sure if any progress is being made on 7.x-2.x, but here's a patch for a bug in the implementation of views_handler_argument_numeric::query().

jordanmagnuson’s picture

jordanmagnuson commented

Any news on this? It would be great to see an "official" 7.x-2.x dev for this module. I agree that 2.x branch is far more useful than the 1.x (which isn't to say that the 1.x was a bad first version of the module--just that the 2.x has made it significantly better). Thanks James for the initial work!

James Andres’s picture

James Andres commented

@theunraveler: Thanks for the patch, I've applied it to the github project.

@davidlerin: Thanks, glad you find it useful :-). I'm really hoping to avoid forking the project to make this branch official, I think creating more module duplication means we all lose :-(.

@rmiddle: What are your thoughts on creating a 7.x-2.x branch for this work?

Casper_Deseyne’s picture

Casper_Deseyne commented
StatusFileSize
new argument_saving_bug-1270244.patch564 bytes

I'm using this module for a project and found a bug while saving the argument options, I created a patch that fixes the problem.

Casper_Deseyne’s picture

Casper_Deseyne commented
StatusFileSize
new argument_saving_bug-1270244.patch1.58 KB

sorry wrong patch code ;)

inolen’s picture

inolen commented

This worked great, thanks a lot for the port.

joachim’s picture

joachim commented

Might I suggest we call it 7.x-3.x to match the version of Views? We may need a 6.x-3.x for Views 6.x-3.x too...

skein’s picture

skein commented

Is there gonna be a official branch release for this one?

Refineo’s picture

Refineo commented

I would be interested in testing official branch release Similar By Terms 7.x-2.0 too. I heavily use Views 3.

jordojuice’s picture

jordojuice commented
Title: I've converted the 6.x-2.x branch to 7.x-2.x for views support » Port 6.x-2.x branch to 7.x-2.x for views support
StatusFileSize
new similarterms-7x-2x-default-view-1270244-12.patch13.64 KB

I noticed no commits have been made on the 6.x-2.x branch in quite a while either. Has development stopped on the Views integrated versions of Similar By Terms? I am maintaining Similar Entries which happens to have a lot of parallels with Similar By Terms. In fact, I got a lot of the Views integration from this module, though it has been updated quite a bit since then. Anyways, I happen to use Similar By Terms on my own sites more than SImilar Entries and I'll gladly volunteer to maintain the 2.x branches if it's needed.

I noticed the default view in this 7.x-2.x port was non-existent, so I put together a patch using some of the code I wrote for Similar Entries Drupal 7 port. I've tested it with Views 3. The patch also fixes a bug I found in the query - ambiguous nid field.

dawehner’s picture

dawehner
Primary language German
commented
StatusFileSize
new 1270244-port.patch21.6 KB

Here is a patch, that worked for me, additional it applies the patch from http://drupal.org/node/1181566

Here is a patch again 6.x-2.x which
a) converts the api to views3 properly
b) adds tests to take sure it works (at least the argument)

OH: I was really confused about all this patches, didn't saw the link to the github repo. Maybe we could merge the approaches

dawehner’s picture

dawehner
Primary language German
commented
StatusFileSize
new 1270244-port.patch85.21 KB

Here is a patch relative to 6.x-2.x which provides all changes from https://github.com/dereine/similarterms/commits/7.x-2.x

BrockBoland’s picture

BrockBoland commented
StatusFileSize
new 1270244-15.patch36.08 KB

The patch in #14 did not apply cleanly to 6.x-2.x for me. Note also that the repo referenced there has moved to https://github.com/dawehner/similarterms

I made some further tweaks to add the default view definition and submitted a pull request on that repo: https://github.com/dawehner/similarterms/pull/2

The attached patch is against 6.x-2.x, and includes everything that @dawehner referred to in #14, as well as the default view that I added on Github.

I know a patch this size is a bit of a beast to try to review, so I'd urge the maintainer(s) to open 7.x-2.x, commit the patch, and begin working from there.

Kimberley_p’s picture

Kimberley_p commented

This may not be ideal for everyone but for me, what I used Similar by Terms for in Drupal 6 I can now do with Views in drupal 7 (where it was a struggle before). This is the best post I have found describing the process that worked well for my needs - may be of use to some of you int he absence of a port to 7 - http://www.metachunk.com/comment/71

James Andres’s picture

James Andres commented

Thanks to Daniel Wehner for taking this project on, I haven't had the bandwidth.

Would be great to see random patches here converted into pull requests on GitHub for consistency. Even better would be to see this back on d.o to limit confusion.

Daniel have you chatted with rmiddle about becoming a maintainer on the similarterms d.o project?

playfulwolf’s picture

playfulwolf commented

Is 2.x branch alive?

skein’s picture

skein commented

I've tested the module on several sites and I can confirm it works as planned.
Can we get an official commit on drupal.org?

quicksketch’s picture

quicksketch
he/him
commented

I've contacted jjeff (the original module developer) to weigh in here too.

jjeff’s picture

jjeff commented

I've granted quicksketch co-maintainership. If needed we can add more permanent maintainers to move the 7.x-2.x branch forward after the initial port.

quicksketch’s picture

quicksketch
he/him
commented
Status: Needs review » Fixed

I've pushed up the last reroll by BrockBoland. Thanks everyone!

quicksketch’s picture

quicksketch
he/him
commented

I've released a new stable 7.x-2.3 to match the 6.x-2.3 version. Thanks again everyone here.

inky@inky3d.com’s picture

inky@inky3d.com commented

Thank you, thank you, thank you!!!

To all who made this module available for D7 , you have no idea how grateful I am!

I've used this on D6 many times and have had such joy with the results. For most of this year I have been working on migrating a site from 6 > 7. Today, 15th Nov, was our launch deadline. During the development, I looked at the alternatives (recommender and similar entries) but neither suited our needs.

Last night we were up until sunrise working out final tweaks to meet our deadline, when I happened to see that Similar by Terms had just been updated. This, seriously, was the final element that we hope will make the site really kick.

Talk about awesome timing! thank you again

(ps, if you're interested: www.designindaba.com)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.