Add tests for Expose the relation-type specific fields

I looked into this more. One of the problem is that relation only exposes the generic list<entity> instead of the entity-type specific ones. As a consequence you cannot introspect the relation structure.

Moreover, the relation module doesn't properly exposes the rid property, so Search API fails to index it.

Same patch with cleanup.

This is nice but I really dislike the $bundle_properties = &$info['relation']['bundles'][$bundle]['properties']; construct (will file issue against entity API as well) why can't we just do $info['relation']['bundles'][$bundle]['properties']; = $bundle_properties at the end?

No we cannot because there could be some properties there to begin with. We could += at the end, but that's going to be ugly very quick. I think this construct is the cleanest we can do.

There could be some properties coming from where?

function relation_entity_property_info() {
  $info = array();
  $properties = &$info['relation']['properties'];

  $properties = array(
    'relation_type' => array(
      'label' => t('Relation type'),
      'type' => 'token',
      'description' => t("The type of the relation."),
      'setter callback' => 'entity_property_verbatim_set',
      'setter permission' => 'administer nodes',
      'options list' => 'relation_rules_get_type_options',
      'required' => TRUE,
      'schema field' => 'relation_type',
    ),
    'endpoints' => array(
      'label' => t('Endpoints'),
      'type' => 'list<entity>',
      'description' => t("The endpoints of the relation."),
      'setter callback' => 'relation_rules_set_endpoints',
      'getter callback' => 'relation_rules_get_endpoints',
      'setter permission' => 'administer nodes',
      'required' => TRUE,
    ),
  );

  return $info;
}

this is the current code and I wish it didnt look that , either. There is no incoming info argument, there is no previous setting of $info['relation']['bundles']. And yes. I would rather fight this here and now than in the entity API where, as I said, I will go next.

You will burn yourself so badly with these unneeded references one day :/

Committed. (Against my better judgement.)

Install eva and this breaks. Rolled back this along with 606d433f65fbb511511397e52a35ea75bb3b5fcc #1265434: Expose relation in an entity list wrapper containing all related entities because I think that one depended on this one.

Edit: reproduction steps, click the 'display fields' of a ctools-exported relation type (might work with db relation type too I didnt check) and click save. If you have eva installed then you get a WSOD.

Edit2: Here is the patch to apply on top of HEAD to reproduce the problem.

upon field info cache clear, eva calls get views which leads to entity api call the properties callback which leads to a call to relation_get_types which calls field_info_instance. The circle is now complete.

Committed, thanks.

Hi,

I attached a patch to test the new feature.

Kálmán

Thanks a ton.