Closed (fixed)
Project:
Location
Version:
7.x-3.x-dev
Component:
Data update
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
6 Sep 2011 at 16:10 UTC
Updated:
31 Oct 2016 at 00:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
esKq commentedSubscribe
Comment #2
Sinovchi commentedThis patch is working for me too. I'm here including location.ss.inc file for South Sudan.
Comment #3
Sinovchi commentedThe attachments: for Sudan and South Sudan
Comment #4
tomogden commentedI have installed this fix in my D7 3.x version, and I believe these files should be committed ASAP on all versions, but for D7 3.x it does not change the country list in Drupal core. You will need something like the Countries module for that.
Comment #5
tomogden commentedSouth Sudan is recognized worldwide as a country. This needs to be fixed!
Comment #6
podarokpostponed before tests fix
#1931088: [META] Fixing tests
Comment #7
podaroktests fixed #1931088: [META] Fixing tests
lets go
Comment #9
tomogden commentedHere is a patch rolled from the files offered in #3, which should test better than the first exploratory patch. But if not, then we will have a known test result to work with for fixing.
Comment #10
tomogden commentedComment #12
tomogden commentedMy fault, diff was not against the correct branch. Here it is again.
Comment #13
miiimoooPlease port this to D7
Comment #14
podarokbumping version
Comment #15
podarok#12: south_sudan-1271066-12.patch queued for re-testing.
Comment #16
podarokcommited and pushed to both 6.x-3.x and 7.x-3.x dev versions
Thanks!
Comment #17.0
(not verified) commentedUpdated issue summary.
Comment #18
miiimoooHas anyone tested this on D7? I looked through the code and I think it requires adding South Sudan to the Drupal core countries list. I could work on a patch I think but wanted to check whether peopel had this working as it is (7.x.-3.1)
Comment #19
miiimoooComment #20
tomogden commentedYes, we performed all due diligence before actually launching with this fix in the U.S. State Department websites, which is why we insisted on it. See https://blogs.state.gov/region/africa . It has proven useful for all our data entry and mapping functions. Below is the stamp from the installed module:
We are running the Countries and Countries Configuration modules as well, which may compensate for what you are seeing. If you can run through a patch to Drupal core, that would be ideal. At the time there just didn't seem much of a change of getting it through.
Comment #21
miiimoooIt doesn't need a patch to Drupal core. This module code does the trick:
Comment #22
jacob.embree commentedThe issue here is fixed. Please open a new issue for any discussion about Drupal core or hook_countries_alter.