When in popup window some subitems are selected, popup window doesn't expand down, so buttons disappear. Theoretically they are still accessible using a , but I believe it shouldn't be like that. I am using Firefox 2, but it is even a bit worse in M$IE7 (the window is too low even at the initial display).

CommentFileSizeAuthor
#7 inline_3.patch548 bytesstborchert

Comments

luti’s picture

luti commented

Arrrgh,

it was a <tab> above, but disappeared - so, are accessible using a <tab>...

stborchert’s picture

stborchert
he/him
Primary language German
commented

Hi.
Not again ;-).
Could you please have a look at #91560 and #93267. Perhaps the solution is already there?!

luti’s picture

luti commented

Sorry, but it doesn't seem to help. According to the solutions suggested, I've tried to remove {$lang_linktonode_label_documents} only, as well as the whole line including it, but there was no visible change. The popup windows are still staying the same, and opening more levels cause the content including buttons at the bottom slowly sliding down, with each new level more...

BTW, popups are not standard popup windows, but as with advanced image and advanced link ones (they look more as a new layer...).

Any other idea?

stborchert’s picture

stborchert
he/him
Primary language German
commented

BTW, popups are not standard popup windows, but as with advanced image and advanced link ones (they look more as a new layer...).

Ah. I guess you have inlinepopups enabled!?
Grml, I need to have an eye on this and have to fix it soon.

luti’s picture

luti commented

stBorchert, how can I disable inlinepopups? I don't remember to enable them anywhere... Or, where to check if they are enabled or not?

stborchert’s picture

stborchert
he/him
Primary language German
commented

Hi.
Go to admin/settings/tinymce end edit your profile. Then expand "Buttons/Plugins" and uncheck "Inline Popups" (should be the right most column near the bottom).
But this should be a temporary "solution". I will try to fix this bad behavior.

stborchert’s picture

stborchert
he/him
Primary language German
commented
Status: Active » Needs review
StatusFileSize
new inline_3.patch548 bytes

Ha, I got it!
It was really simple: tinyMCE allows you (the plugin developer) to specify whether the plugin should be opened using inline popups (if enabled) or not. And no, I don't want it! :-)
Please test the attached patch or change the following line of editor_plugin.js (in tinymce/jscripts/tiny_mce/plugins/linktonode):
tinyMCE.openWindow(template, {editor_id : editor_id, inline : "yes", resizable: "no"});
to
tinyMCE.openWindow(template, {editor_id : editor_id, inline : "no", resizable: "no"});.

And don't forget to refresh (STRG+R) the browser before loading.

luti’s picture

luti commented

stBorchert, thank you very much for a quick solution.

The "inline popups" setting is so well hidden among the buttons, that I've never payed attention to it. I've selected for administrator just everything, and for the other users just what I've thought they really need (basics), and never tried to see what the other options really do... But, this is not the subject here. ;-)

Your patch (as it is) would be a solution, if my Firefox (now, blame it or some plugin, who knows...) wouldn't set the popups wrong (not an issue only in TinyMCE...; M$IE doesn't have this problem, as well as inline popups in Firefox don't...?!). Therfore, I've changed also a "resizable" part to "yes" (in TinyMCE, I've already set it to "yes" before...), so I can adjust the initial width (to see also the right part of the popup window incl. a "cancel" button). After that, popup window resizes fine (grow and shrink as needed).

The same is also needed for a linktomenu part (I've already done it there as well, works fine).

stborchert’s picture

stborchert
he/him
Primary language German
commented

if my Firefox (now, blame it or some plugin, who knows...) wouldn't set the popups wrong

Is the popup window to high (something like this screenshot)?

luti’s picture

luti commented

No, don't worry, it is the right height, but only approx. half a size it should be.

But, as I've said, it has nothing to do with a "Link to content" plugin, as I am facing this issue with I believe practically all other popups in Drupal (and not only in TinyMCE), which are more or less wrong size (for example, I've made a simple adaptation of the old print module to generate a small popup windows, and even I specify the dimensions, it is not respected by Firefox... It seems that it will be a proper size sometimes (in a moment the window appears), but immediately after that, in next moment, it shrinks in width to something more narrow...). In M$IE I don't see this problem. I have no idea where it is coming from...

And, it was the issue with Firefox 1.5, and it is stil with the last 2.0.0.2. Also it is the same on my 4.7 production site and on my 5.1 test site. But, as said, I make all windows resizable, so they are usable, even the solution is not the perfect one...

stborchert’s picture

stborchert
he/him
Primary language German
commented
Status: Needs review » Fixed

Indeed, that sounds really strange.
I commited the patch to cvs so noone should get any problems with InlinePopups anymore (hopefully).

greetings,

Stefan

stborchert’s picture

stborchert
he/him
Primary language German
commented
Status: Fixed » Closed (fixed)