Is there a good reason why troll uses the 'administer site configuration' permission for all of its access rules, instead of a specific 'administer troll' perm? I'll submit a patch to add a perm within a day or so unless I'm convinced otherwise.

CommentFileSizeAuthor
#2 troll.module.127815.patch981 bytesjaydub

Comments

citizenex’s picture

citizenex commented

Hello, have you done this yet? 34 weeks is a long time..?
If so please upload a patch.

jaydub’s picture

jaydub commented
Version: master » 5.x-1.x-dev
Status: Active » Needs review
StatusFileSize
new troll.module.127815.patch981 bytes

see attached patch.

adds a new permission 'administer troll' and uses that permission for all admin actions except for the settings page which remains in the hands of 'administer site configuration'

jaydub’s picture

jaydub commented
Status: Needs review » Fixed
Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.