Problem/Motivation

The span tag inside the noscript tag causes xhtml validation errors.

Proposed resolution

Change the span to a div. See patch.

Remaining tasks

Consider including some default CSS to make the new div display:inline.

User interface changes

None, although it's possible someone is relying on the default display style of the span and would need to add a rule to make the div display:inline.

CommentFileSizeAuthor
#6 language_switcher_dropdown-noscript_validation-1272202-6.patch517 bytesmanfer
#1 1272202-noscript_validation-1.patch583 bytestedfordgif

Comments

tedfordgif’s picture

tedfordgif commented
Status: Active » Needs review
StatusFileSize
new 1272202-noscript_validation-1.patch583 bytes
manfer’s picture

manfer commented
Status: Needs review » Fixed

Didn't realized there was and issue about this and it has been already solved in new version. The solution used was just adding a div instead of replacing the span.

manfer’s picture

manfer commented

There is no need to have both div and span so better I'm going to push the patch in #1 by tedfordgif.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

manfer’s picture

manfer commented
Version: 7.x-1.x-dev » 6.x-1.x-dev
Status: Closed (fixed) » Active

Needs to be backported to 6.x version

manfer’s picture

manfer commented
StatusFileSize
new language_switcher_dropdown-noscript_validation-1272202-6.patch517 bytes
manfer’s picture

manfer commented
Status: Active » Fixed

pushed to 6.x-1.x development branch

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.