Closed (outdated)
Project:
Flag
Version:
7.x-3.x-dev
Component:
Flag core
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
7 Sep 2011 at 18:31 UTC
Updated:
19 Aug 2025 at 11:58 UTC
Jump to comment: Most recent
Comments
Comment #1
quicksketchI think in order to do this we need to add a column to the database for "overridden" so we can identify which flags have received custom changes on top of the feature and which ones are in the default state. Just like a normal feature, "overridden" flags should still exist even if the feature is disabled/deleted. If the flag is in the default state then I agree it should be deleted along with the feature.
Comment #2
joachim commented> add a column to the database for "overridden"
In anticipation of eventually moving to using CTools for exports, we should probably use the same system -- IIRC it's one of DB / Code / overridden.
Comment #3
joachim commentedHmm views don't have a status column. Maybe it's a property of the object that CTools adds when loading up configuration.
Though a big difference here is that a view that's in code is *just* in code and never saved to the DB until customized, whereas we save a flag to the DB as soon as it's loaded from code.
Comment #4
joachim commented... though on the other hand, things like node types *do* write code items to the database immediately and then track them with an extra column.
My take on this bug is that it's a minor inconvenience, and not one that will come up terribly often (I hardly ever delete things I've put into a feature) -- but it's a complex fix. Therefore it may be we should postpone this, at least until I've figured out which of the two patterns D8 config system follows (so we don't change the DB in one direction only to have to change it back).
Comment #5
ivnishClosed as outdated because Drupal 7 is EOL