Wondering what the reason behind requiring entity_tokens is for Rules. The module causes problems when used in combination with Token module (#1272560: Entity tokens duplicates field tokens created by token module) and the sheer amount of tokens that the module creates was something the token UI was not designed to handle. This is what is causing memory problems for any site that has a module that depends on Rules (Drupal Commerce). Could this dependency possibly be dropped?

Comments

bforchhammer’s picture

Component: Rules Core » Rules Engine

I am experiencing this very problem... subscribing.

fago’s picture

Status: Active » Closed (won't fix)

entity tokens is needed for Rules in order to ensure that there are tokens for that what people have available in the data selector - thus it's critical for UX.

Without entity-tokens something available during data selection might be suddenly not available for token replacements. To prevent that we make sure entity tokens is there by depending on it - so we can provide a consistent UX.

Also, I don't see what removing the dependency of entity-tokens should help. The memory problem of token module remains and would pop up again as soon as there are enough fields referring to other entities. But let's keep that discussion in the issues dedicated to that.

Dave Reid’s picture

"The memory problem of token module remains"

No it doesn't because it worked within limits until people started installing Entity Tokens via Rules or other modules.

ethanw’s picture

Note that along with http://drupal.org/node/1252840, this creates a UX issue throughout sites, independent of the need for these tokens in Rules used on a given site.

Token Tweaks can address this, but not requiring the module unless needed would be my preference as I'm working through performance issues on new sites.