Module numbers display incorrectly if direction is set to RTL

yhager - March 13, 2007 - 09:03
Project:Drupal
Version:7.x-dev
Component:system.module
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Description

When working with a RTL (right-to-left) theme, such as garlandrtl, the version numbers of modules is displayed in an awkward way.

The update_status module defines a special div around the version numbers, and thus there is a trivial fix: http://drupal.org/node/126568.

There is no such a div in the core, and therefore I have opened this bug.

#1

yhager - April 10, 2008 - 06:41
Version:5.1» 6.x-dev
Component:install system» system.module
Status:active» patch (code needs review)

Attached is a patch that adds a proper class to the version numbers, and defines this class as 'direction:ltr'.

AttachmentSize
yh.patch1.2 KB

#2

z.stolar - April 10, 2008 - 08:20
Status:patch (code needs review)» patch (reviewed & tested by the community)

Tested and approved. But...
I think that while we're there, we might as well do the same for the Module Name column, since module names are (almost?) always in English, thus ltr.

#3

yhager - April 10, 2008 - 12:16

Not sure we want to link these two together, however, I looked at the code and it looks like the module name does not get translated. If someone can confirm this, I can add this to the patch, otherwise, let's open a different issue for the names thing.

#4

Gábor Hojtsy - April 25, 2008 - 21:02
Version:6.x-dev» 7.x-dev

Committed to Drupal 6 and also ready for Drupal 7.

BTW module names are not translated on purpose, with the idea that it is easier to identify a module you just installed, without knowing what crazy translation your language team provided for that. So a new issue on that might indeed be applicable.

#5

Dries - April 30, 2008 - 06:48
Status:patch (reviewed & tested by the community)» fixed

Committed to CVS HEAD as well. Thanks yhager.

#6

Anonymous (not verified) - May 14, 2008 - 06:54
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

#7

yhager - June 18, 2008 - 05:20

BTW module names are not translated on purpose, with the idea that it is easier to identify a module you just installed, without knowing what crazy translation your language team provided for that. So a new issue on that might indeed be applicable.

There you go: #271826: Module names display incorrectly if direction is set to RTL

 
 

Drupal is a registered trademark of Dries Buytaert.