The shutdown function should be registered in hook_boot(), not hook_init(). In hook_init() it does not get added on cached pages. This is bad.

CommentFileSizeAuthor
#1 hook_boot.patch739 bytesxjm

Comments

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new hook_boot.patch739 bytes
xjm’s picture

xjm
she/her
Primary language English
commented
Status: Needs review » Fixed

http://drupal.org/commitlog/commit/364/ee9ea13b07129677926e5777ccb604b93...

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

xjm’s picture

xjm
she/her
Primary language English
commented
Priority: Critical » Normal
Status: Closed (fixed) » Needs review

So, based on #1313912: undefined function node_access_needs_rebuild() on cached anonymous requests, I think this needs to be reverted.

xjm’s picture

xjm
she/her
Primary language English
commented
Title: Move registration of shutdown function from hook_init() into hook_boot() » [Rollback] Move registration of shutdown function from hook_init() into hook_boot()
xjm’s picture

xjm
she/her
Primary language English
commented
Status: Needs review » Fixed

Fixed in the next -dev build:
http://drupal.org/commitlog/commit/364/e37bd28c5cca80127c805bd11ef03bfe9...

xjm’s picture

xjm
she/her
Primary language English
commented

Okay, wow, that commit stuck the hunk in the wrong place and is essentially totally bogus. Thank you, test suite.

Fixed here:
http://drupal.org/commitlog/commit/364/5a17b5e4ed655c249ef4691e18a6e78a9...

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.