The unchanged values stored into $form['#signup'] while editing a signup are altered together with the submitted values, since the $signup variable holds an object reference in PHP5. This causes troubles to Signup status which cannot tell if a status has changed and perform the needed actions.

CommentFileSizeAuthor
#3 signup-preserve_signup_values-1273174-3.patch945 bytesjerenus
#1 signup-1273174-1.patch594 bytesplach

Comments

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Status: Active » Needs review
StatusFileSize
new signup-1273174-1.patch594 bytes

Cloning the $signup object before altering it does the trick.

This is present in both the 7.x and 6.x branches and needs backport.

jerenus’s picture

jerenus commented
Status: Needs review » Needs work

I saw the line drupal_clone here.
This will causes an error if called because it has been removed in drupal 7.
This drupal_clone function was used to provide a substitute clone() function for PHP4.
We need a new patch here.

 function signup_edit_form_save_submit($form, $form_state) {
-  $signup = $form['#signup'];
+  $signup = clone($form['#signup']);
   if (!empty($form_state['values']['signup_form_data'])) {
     $signup->form_data = $form_state['values']['signup_form_data'];
   }
jerenus’s picture

jerenus commented
Status: Needs work » Needs review
StatusFileSize
new signup-preserve_signup_values-1273174-3.patch945 bytes

patch here.