Port Chrome Frame to Drupal 7

subscribe

subscribe

subscribe

Hey everybody,

This module is marked seeking new maintainer and no further development. I've looked at the code and it doesn't seem to be very complicated. Do you think we all can work together to update this module ourselves? Anyone have any experience maintaining modules?

John

I might be able to port it. I'll assign it to myself.

Edit: While I will port it, I have no way to test it since none of my computers run Windows. You'll have to test it for me.

Here it is.

Please note that I've tested the patch and it's not breaking my drupal site, but I don't know if it is working since I don't use IE.

I've just updated all the functions to the D7 counterparts, and since the module is small and it required only 5 changes it just might work.

To patch, use:

patch -p1 < port-to-d7-1273626.patch 

one more thing. I just couldn't make the link to show up at admin/config.. You'll just have to access the configuration page at the modules area (see the Config link next to the module's name)

I think originally that's how it works. But maybe I could add another option to hide for IE9

I've just been added as a co-maintainer of this module and I've created a new branch with the patch in #7 for you to test.

Please keep testing, once it works, I'll release a stable version

Done. Please test. I'm closing this to avoid adding more feature requests to this issue.

That was probably because of the version. The dev tar wasn't recreated by the time you downloaded the module. Please update the module since the patch was committed http://drupalcode.org/project/chrome_frame.git/commit/185ef95

Great job guys! This will be helpful to us all. I'll test it tonight.

Thanks for the image.

I'm releasing a first alpha.

The Drupal 7.8-1.x head was majorly bugged. The meta tag didn't include at all and the configuration menu wasn't in the admin control panel.

This patch fixes these issues while adding a few features I needed (IE7 or less detection, modal overlay and url redirect when installation complete).

I'll test tomorrow. A couple of things I have to mention:

1. I've been trying to do a separation between the installation and the use. So, if you don't want to ask the user to install GCF but it the user already has it installed it will use it. Does the meta tag solves this?
2. Why did you change the menu item path? Is there any problem with the old one?

1. The meta tag does not trigger any prompting, it simply notifies IE to use Chrome Frame to render the page if the latter is already installed. Without the tag, having Chrome Frame installed makes no difference at all, the page continues to render in IE.

The prompting is triggered by Google's javascript at the page bottom, which is itself controlled with conditional comments. (Those are configurable through the module settings form.)

Thus, if you don't want the meta tag in your pages, you should just disable the module, otherwise what's the point?

2. The menu item path made it so the module did not show up in the Drupal configuration dashboard. You could only access the configuration from the link on the module activation panel.

Is there any reason why we don't want the menu link to show up in the Drupal configuration dashboard?

Uh? The fix does make it show on the dashboard. It didn't before.

I'm sorry, my bad. I'll commit.

Committed. Thanks. I also changed the variables keys so all options are consistent.

http://drupalcode.org/project/chrome_frame.git/commit/0356a06

This will probably need to be backported.

changes applied to 6.x also.