This just started for me. Problem was also noted in RC15 so I upgraded to RC16 and problem persists. The facebook connect button is duplicated. The larger button on right is non-functional and gives user the impression that it is non-functional. The smaller, easily overlooked button on left IS functional. This problem is present in Firefox and IE. I am marking this has critical because a non-functioning button makes facebook connect obsolete.

See attached screenshot for reference.

CommentFileSizeAuthor
#5 fb_user_1273828.patch558 bytesjolidog
fb_connect_button.JPG19.37 KBtpainton

Comments

tpainton’s picture

tpainton commented

Messing around with this.. If I simply add a print $button to theme_fb_login_button() I get a very pretty button printed at the top left corner of my page.. It works as well. There is no duplication.. Still trying to figure this out.. Should be added as well that another issue has this as a problem, so it's not my page alone.

Macronomicus’s picture

Macronomicus commented

yes I noticed this too in the latest 7.x dev but hit some other roadblocks before investigating why the button looked off... seems there are some updates coming soon with several patches and the looming 3.0 deadline

tpainton’s picture

tpainton commented
Status: Active » Needs review

I solved it.. Facebook made a change I think..

http://developers.facebook.com/docs/reference/plugins/login/

Notice that there are two ways to add a button.. One uses FBML the other you simply assign a class of, "fb-login-button"... It appears that the wrapper class for the layout of the button in fp_user.module, line 553 ALSO use this same exact class.. THEREFORE the button is being called from facebook twice.

If you simply change the class on line 553 to , "fb-login-button-wrapper", it solves the problem.

So, I would propose a test of this.. seems simple enough, and there is no CSS to change..

I think this is a fix.

spesso’s picture

spesso commented

+1 for me... worked great! Also HTML5 implementation of the button, instead of FBL one, still works.

jolidog’s picture

jolidog commented
StatusFileSize
new fb_user_1273828.patch558 bytes

Here is the patch...

Dave Cohen’s picture

Dave Cohen commented

I'm going to change the class to something that does not start with "fb-", because clearly facebook considers anything that starts with that to be theirs. Maybe "fb_user-login-button" or "fb_user-login-button-wrapper". Any preference?

Dave Cohen’s picture

Dave Cohen commented
Issue tags: +fb3-blocker

tagging to make sure it gets fixed.

Dave Cohen’s picture

Dave Cohen commented
Version: 6.x-3.0-rc16 » 7.x-3.x-dev
Status: Needs review » Patch (to be ported)

I changed it to "fb_user-login-button-wrapper". Committed to D6, still need to do on D7.

I just want to say thanks. Although someone brought it to my attention that class=fb-login-button started doing weird things, no one bothered to point out that modules/fb was the culprit, until now.

Dave Cohen’s picture

Dave Cohen commented
Status: Patch (to be ported) » Fixed

Should be fixed in dev releases. Please let me know if not.

tpainton’s picture

tpainton commented

NP!, Thanks for an amazing module.

amolinari’s picture

amolinari commented
Status: Fixed » Active

sorry but where is 6.x branch :-) we are planning to release a site today and it disappeared (yesterday it was there!) please con you help me solving this ?

Dave Cohen’s picture

Dave Cohen commented
Status: Active » Fixed

Links are back. Upgrade to 3.1 when you have a chance.

Automatically closed -- issue fixed for 2 weeks with no activity.