i'm not sure if this is a browser compatibility issue, or an interaction with other scripts, but in some cases i've found that when you click the live person image, a new window will open *and* the original window will follow the href to the chat.

then both new and original windows are resized per the block settings.

as a workaround, live-person.js could replace the href of the a tag after it adds the onclick. i'll provide some patches.

CommentFileSizeAuthor
#4 replace_href-1273848-4-D6.patch847 bytesfirebus
#4 replace_href-1273848-4.patch778 bytesfirebus
#1 replace_href-1273848-1-D6.patch337 bytesfirebus
#1 replace_href-1273848-1.patch365 bytesfirebus

Comments

firebus’s picture

firebus commented
Status: Active » Needs review
StatusFileSize
new replace_href-1273848-1.patch365 bytes
new replace_href-1273848-1-D6.patch337 bytes

very simple. but maybe i'm missing something and there's another reason for/way to resolve this problem...

nicholas.alipaz’s picture

nicholas.alipaz commented
Status: Needs review » Needs work

Maybe this is related to this bug: http://www.google.com/search?channel=fs&q=jquery+attr+onclick&ie=utf-8&o...

I think we should explore better method than "onclick". $(this).click(); perhaps?

firebus’s picture

firebus commented

iirc, i had some trouble with .click(). i'll do some cross-browser testing with various strategies and will see what i get/post code in case i'm doing something dumb :)

thanks as always for the feedback!

firebus’s picture

firebus commented
StatusFileSize
new replace_href-1273848-4.patch778 bytes
new replace_href-1273848-4-D6.patch847 bytes

okay, here's a version that uses jQuery.click(); correctly, i think...

firebus’s picture

firebus commented
Status: Needs work » Needs review
nicholas.alipaz’s picture

nicholas.alipaz commented
Status: Needs review » Fixed

Committed to dev of both branches.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.