geolocation_googlemaps.js creates an "My Location"-link if the browser supports navigator.geolocation. This string isn't created using Drupal.t(), thereof this issue and patch. :)

Comments

bambilicious’s picture

StatusFileSize
new1.29 KB
jm.federico’s picture

Status: Active » Fixed

Thank for the patch

Commited to latest dev.
http://drupal.org/commitlog/commit/5688/98b7da12745f62c4edfcf9b5970109a1...

Cheers

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Sinan Erdem’s picture

Status: Closed (fixed) » Active

Similarly;

Get location

and

Enter an address / location in the textfield or you can also click on the map to set a marker, or use your browser geolocation system by clicking this link:

Are also not translatable...

hutch’s picture

You need to update to 7.x-1.1 or dev

Sinan Erdem’s picture

I already updated, cleared the cache, refreshed strings, but it doesnt change anything. I cannot find those strings that are written inside t().

hutch’s picture

I searched geolocation folder (current git pull):

grep -rni 'get location' *

and found
modules/geolocation_googlemaps/geolocation_googlemaps.module:353: '#markup' => t('Get location'),
looked on line 353 and it is there.

searched again

grep -rni 'browser geolocation system' *

and found
modules/geolocation_googlemaps/geolocation_googlemaps_widget.js:210:

$('#geolocation-help-' + i + ':not(.geolocation-googlemaps-processed)')
.addClass('geolocation-googlemaps-processed')
.append(Drupal.t(', or use your browser geolocation system by clicking this link') +': <span id="geolocation-client-location-' + i +
'" class="geolocation-client-location">' + Drupal.t('My Location') + '</span>');

looked in geolocation_googlemaps_widget.js line 210 and it's all wrapped in Drupal.t()

So the problem lies elsewhere.

Sinan Erdem’s picture

Status: Active » Fixed

Hi Hutch,

Thanks for the reply. I think I have a problem elsewhere. I cannot see any string that are inside t() from any module. JS strings are ok, but php strings are not. (Do you know anything about this different problem?)

So, sorry to reopen this issue again. Closing...

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.