Line 351 of uc_addresses.module says:

t('Click !here to manage your saved addresses.',

First, this is Click Here Syndrome: you should never use the words "click here" in a website but make the actual description act as a link instead. Second, how are we supposed to localize this? :-)

Drupal.org, in the documentation accompanying t(), has clear descriptions of how to specify links. Please, follow those guidelines. In this particular case:

t('Edit your <a href="@saved-address">saved addresses</a>.', array('@saved-address' => ...))

Comments

megachriz’s picture

megachriz
Primary language Dutch
commented
Assigned: Unassigned » megachriz

You are absolutely right. In fact, I'm not happy about this line either. I shall change it in the code when I get a chance.

About your localize question: the string can already be translated. See #1080092: !here translation on page /cart/checkout nowhere to find for more discussion on this subject.

megachriz’s picture

megachriz
Primary language Dutch
commented
Status: Active » Fixed

Fixed in 6.x-1.x-dev.

I have changed the string into "Go to your <a href="@address-book">address book</a> to manage your saved addresses.".

djg_tram’s picture

djg_tram commented

Thanks, perfect. :-)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.