The node types listed at admin/settings/search_by_page/edit/X seem to be in no particular order. It would be better if they were in alphabetical order by human label.

Patch coming.

CommentFileSizeAuthor
#4 ordering-settings-1274154.patch2.18 KBjhodgdon
#1 1274154.search_by_page.node-type-order.patch855 bytesjoachim

Comments

joachim’s picture

joachim commented
Status: Active » Needs review
StatusFileSize
new 1274154.search_by_page.node-type-order.patch855 bytes

Here's a patch.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

Looks reasonable -- I'll test it out. Needs port to D7 also.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

I looked at this patch again. It shouldn't actually be necessary to do the asort here, since node_get_types('names') already does this. So I'll test it without the asort... calling node_get_types('names') instead of just node_get_types() is a good idea. Will also need to figure out how to port this to drupal 7...

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Version: 6.x-1.x-dev » 7.x-1.x-dev
Status: Needs review » Fixed
StatusFileSize
new ordering-settings-1274154.patch2.18 KB

OK, I've committed fixes for this, in both the Nodes and Attachments modules, for d6 and d7. Quite a bit simplified from the suggested patch, but it appears to work fine. (attached is d7 patch if you are interested).

I plan to make a new release of d6/d7 versions shortly, but until then you can get it from the dev download (check the time stamp and make sure it is after this comment - they are only updated every 12 hours!) or from git.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.