If a file is called 'MYFILE.DOC' then it's not indexed, because array keys are used to find the right helper from search_files_get_helpers().

CommentFileSizeAuthor
#1 1274254.search_by_page.file-extension-lowercase.patch583 bytesjoachim

Comments

joachim’s picture

joachim commented
Status: Active » Needs review
StatusFileSize
new 1274254.search_by_page.file-extension-lowercase.patch583 bytes

Here's a patch.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Priority: Major » Normal
Issue tags: +Needs tests

Actually, you can just define a new helper on the Helpers page to deal with .TXT, .DOC, or whatever, using the same definition as the lower-case helper, so I wouldn't classify this as "major", since there's an easy work-around.

Also, it needs a test, and a port to D7.

joachim’s picture

joachim commented

That would be a pretty ugly workaround though! Also, it wouldn't cover the arguably highly unlikely cases of mixed cases in the extension.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

I'm not saying I won't add the code to Search by Page. Just saying it's not a huge major critical issue as there is a work-around. Also, it needs a test.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

I have just committed a fix for this to both 6.x and 7.x, including a test. It seems to work...

I'm going to make a new release version for both, and this will be part of it.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Fixed

Automatically closed -- issue fixed for 2 weeks with no activity.