Attached is a patch that adds query tags to the queries in achievements_totals() and achievements_totals_user(). This will allow module developers to alter the queries if necessary.

CommentFileSizeAuthor
query_tags.patch1.25 KBmakononov

Comments

morbus iff’s picture

morbus iff
they/them
commented

Sounds good, but why wouldn't we want tags for all the queries, versus just these two?

morbus iff’s picture

morbus iff
they/them
commented
Status: Needs review » Fixed

Committed.

makononov’s picture

makononov commented

Sorry for the late reply -- These two were necessary for my immediate needs, and I could see others wanting to modify those particular queries as well. Adding them to all the queries could just generate useless noise, so I would think it would be better to add them as the need develops.

Same thing with adding in hooks. Some are necessary and helpful. Too many just clutters the code and doesn't serve any real purpose.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.