Empty upload video file + empty path to video file = node wont load and many "video not supported" messages

After looking a bit more at the video.module code, the path to file starts off required, but once the upload video plugin (video_upload.module) is enabled it is changed to not required, which makes sense, but that also means that if someone submits a video without uploading a video or giving it a path, it is allowed to go through, and then when you view the video you get the "video type not supported" messages in an endless loop (the longer you let the page try to load, the more messages it creates, hench the endless loop)

My problem is not a matter of a video not uploading, but of a user not even selecting a video to upload and then submitting the form. Your problem is related though, because while you are having problems with it uploading, the form is still submitted with no video that it is pointing to, and for some reason this causes an endless loop, this is a coding problem, not a browser type problem.

Changed to bug report, because this seems like it is becoming more of a bug.

Its amazing how one small line of code can cause an endless loop. After looking throughout the video.module i found out why it was getting stuck in an endless loop. There is a switch statement that checks what format the video is in, and if it doesn't find one, it sends the "Video type not supported message" and then it tries to load the node again. I see the reasoning for this, if you have the play tab enabled this would work fine, but since i don't, the video is part of the node, and so it just gets stuck doing the same thing over and over.

I'm not going to put a patch out because it only happens when the play tab is disabled and i don't know how to fix it to work with the tab enabled, i also don't know how to generate a patch!

However, if you are getting the same as me, heres the code that will fix it:

Right around line 947 of the video.module file (yours may be different, i've made slight modifications to mine) you have this switch statement:

switch (_video_get_filetype($node->vidfile)) {
    case 'divx':
      return theme('video_play_divx', $node);
    case 'mov':
    case 'mp4':
    case '3gp':
    case '3g2':
      return theme('video_play_quicktime', $node);
    case 'rm':
      return theme('video_play_realmedia', $node);
    case 'flv':
      return theme('video_play_flash', $node);
    case 'swf':
      return theme('video_play_swf', $node);
    case 'dir':
    case 'dcr':
      return theme('video_play_dcr', $node);
    case 'wmv':
      return theme('video_play_windowsmedia', $node);
    case 'ogg':
      return theme('video_play_ogg_theora', $node);
    case 'youtube':
      return theme('video_play_youtube', $node);
    case 'googlevideo':
      return theme('video_play_googlevideo', $node);
    default:
      drupal_set_message('Video type not supported', 'error');
      drupal_goto("node/$node->nid");
      break;
  }

All you need to do is comment out or delete the drupal_goto("node/$node->nid"); line right near the bottom of that code.

If someone can figure out how to fix this so that it works with both the play tab enabled and disabled, then that would be great.