Hi there. I installed the D7 version of the module to see if it was usable for my site but immediately when I tried accessing the Filter Formats and when I tried to create a new content I got these warnings, and no tips for the available shortcodes appeared (as per screenshot):
Notice: Undefined variable: args in _shortcode_filter_tips() (line 76 of /var/www/site/sites/all/modules/contrib/shortcode/shortcode.module).
Warning: call_user_func_array() expects parameter 2 to be array, null given in _shortcode_filter_tips() (line 76 of /var/www/site/sites/all/modules/contrib/shortcode/shortcode.module).
I dived into the code and found the function and the line reported in the warnings and $args is indeed not being defined anywhere. Changing '$args' to 'array($format, $long)' seems to solve the issue and the tips start appearing on the wysiwyg when creating content. As I might need this module for a D7 project I 'll continue testing and report my findings here.
Thanks a lot for your time and the module.
Pavlos
| Comment | File | Size | Author |
|---|---|---|---|
| shortcode_no_tips.png | 14.93 KB | pavlosdan |
Comments
Comment #1
denes.szabo commentedCommitted a fix into the d7-2.x-dev version. Pls. test it!
Comment #2
pavlosdanHi Denes will do. Thanks a lot.
Comment #3
denes.szabo commentedstatus change only.
Comment #4
pavlosdanNotices & warnings gone. Thanks
Comment #5
denes.szabo commentedThx. closing this.
(I checked other shortcode modules, there are lot of problems. I will fix all of them.)
Comment #6
pavlosdanCool. Was just about to submit an issue about the wysiwyg integration not working (the list of enabled shortcodes to choose from does not appear in the shortcode box). But you seem on top of it :)
Let me know if you need any help or when you commit something that needs testing. More than happy to help create a stable release for this.
Comment #6.0
pavlosdanupdating array() to array($format, $long)