Needs review
Project:
Microcart Block
Version:
6.x-1.3-beta1
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
11 Sep 2011 at 10:30 UTC
Updated:
24 Apr 2013 at 10:25 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
Anonymous (not verified) commentedSubscribe
Comment #2
tinefin commentedUpgrade to D7 attached, patched against the master branch.
I have it installed and working on a site to go live soon.
Comment #3
Quarantine commentedThank you so much for that tinefin! I'll try and patch it and test it out soon when I have some free time.
Comment #4
tinefin commentedAwesome! My pleasure :)
Cheers
Comment #5
rich.yumul commentedtinein - thanks so much for your contribution!
Quarantine - any results from using the patch? It would be great to release a D7 version.
Comment #6
Quarantine commentedSorry for the late response! Have been so busy this entire week and I'm finally slightly free today.
Thing is, been going at this for an hour now but I'm having trouble patching it in both Windows and Ubuntu server. I got this result in Ubuntu:
I'll try and see if I can figure out what's wrong exactly.
Edit: I tried to apply the patch manually instead, and I'd like to think that it works (after removing some extra lines in uc_microcart.info in order to make my D7 system to allow the installation)!
My only problem is, I can definitely see the microcart appearing after putting the Microcart block at a particular region, but I also saw this error message appearing:
Notice: Undefined index: attributes in theme_image() (line 1511 of /var/www/URL.com/includes/theme.inc).Any ideas what that could be/mean?
Comment #7
tinefin commentedHey
Thanks, I'll have a look at it tonight and see what it can be :)
It's running w no errors on our site, but I'll try and put it on a fresh install and see if I can reproduce the error.
/Tine
Comment #8
tehn commentedActually, it's internal error and as drupal API suggest we should not use theme_image().
Try to replace line
$img = theme_image(array('path' => drupal_get_path('module', 'uc_microcart') . '/images/cart1.gif'));in microcart.tpl.php with :
$img = theme('image', array('path' => drupal_get_path('module', 'uc_microcart') . '/images/cart1.gif'));Also would be nice to replace this line in patch.
Comment #9
edmonkey commentedHi, anyone have a stable release for D7?
Comment #10
Rahul Tiwari1 commentedHello tinefin ,
Its working fine.. you are awesome..