Hi there,

I'm interested to see this module ported to D7. Are there any plans to do so?

CommentFileSizeAuthor
#2 port_to_d7-1275574-2.patch3.74 KBtinefin

Comments

Anonymous’s picture

Subscribe

tinefin’s picture

Status: Active » Needs review
StatusFileSize
new3.74 KB

Upgrade to D7 attached, patched against the master branch.
I have it installed and working on a site to go live soon.

Quarantine’s picture

Thank you so much for that tinefin! I'll try and patch it and test it out soon when I have some free time.

tinefin’s picture

Awesome! My pleasure :)

Cheers

rich.yumul’s picture

tinein - thanks so much for your contribution!

Quarantine - any results from using the patch? It would be great to release a D7 version.

Quarantine’s picture

Sorry for the late response! Have been so busy this entire week and I'm finally slightly free today.

Thing is, been going at this for an hour now but I'm having trouble patching it in both Windows and Ubuntu server. I got this result in Ubuntu:

patching file microcart.tpl.php
patching file uc_microcart.info
Hunk #1 FAILED at 2.
1 out of 1 hunk FAILED -- saving rejects to file uc_microcart.info.rej
patching file uc_microcart.module
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file uc_microcart.module.rej

I'll try and see if I can figure out what's wrong exactly.

Edit: I tried to apply the patch manually instead, and I'd like to think that it works (after removing some extra lines in uc_microcart.info in order to make my D7 system to allow the installation)!

My only problem is, I can definitely see the microcart appearing after putting the Microcart block at a particular region, but I also saw this error message appearing:

Notice: Undefined index: attributes in theme_image() (line 1511 of /var/www/URL.com/includes/theme.inc).

Any ideas what that could be/mean?

tinefin’s picture

Hey

Thanks, I'll have a look at it tonight and see what it can be :)
It's running w no errors on our site, but I'll try and put it on a fresh install and see if I can reproduce the error.

/Tine

tehn’s picture

Actually, it's internal error and as drupal API suggest we should not use theme_image().
Try to replace line
$img = theme_image(array('path' => drupal_get_path('module', 'uc_microcart') . '/images/cart1.gif'));
in microcart.tpl.php with :
$img = theme('image', array('path' => drupal_get_path('module', 'uc_microcart') . '/images/cart1.gif'));

Also would be nice to replace this line in patch.

edmonkey’s picture

Hi, anyone have a stable release for D7?

Rahul Tiwari1’s picture

Hello tinefin ,

Its working fine.. you are awesome..