Description

Provides adminsitration settings to handle /node page access.

Once it is activated there are three posible configurations:

  • Core - Drupal core will handle node page access as usual: all users with 'access content' permission
  • Disabled - Nobody will be able to access /node
  • By permission - Access will be handled by a new permission: 'access node page'

Other modules providing same functionality

I haven't found a similar module.

Drupal version

It is for Drupal 7 but if in case users need a D6 version, it is easy to provide.

Sandbox url

Link to my sandbox.

Git instructions

git clone --branch master git.drupal.org:sandbox/jherencia/1275646.git node_page_admin

Comments

jherencia’s picture

jherencia commented
Issue summary: View changes

Required information provided.

jherencia’s picture

jherencia commented
Issue summary: View changes

Changed git user.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs review » Needs work

* info file lists "core" twice
* "version" in info file is discouraged http://drupal.org/node/542202
* install file does not contain a class, so no need to list it in the info file
* same for the module file
* why do you set the variable in the install function? You have a default fallback anyway.

jherencia’s picture

jherencia commented
Status: Needs work » Needs review

Thank you, I've made those changes.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs review » Needs work

* comment "Changes variable names and" and what?
* comment "Install file for node_page_settings module." I think the module name is node_page_admin, no?
* indentation errors in node_page_admin_menu() and node_page_admin_settings_form(), use 2 spaces everywhere
* README.txt is missing

jherencia’s picture

jherencia commented
Status: Needs work » Needs review

Again, thank you.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs review » Needs work

* Git release branch is missing, see http://drupal.org/node/1015226
* lines in README.txt should not exceed 80 characters
* would be nice to have the path to the configuration page also in README.txt
* node_page_admin_menu_alter(): the switch() has a default case that does nothing, so you can remove the default case.

jherencia’s picture

jherencia commented
Status: Needs work » Needs review

I didn't know this, sorry.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs review » Reviewed & tested by the community

* "case NODE_PAGE_ADMIN_CORE" also in this case nothing is done, so remove this case as well.

but this is just a minor thing. RTBC for me!

nevets’s picture

nevets commented
Status: Reviewed & tested by the community » Needs review

What does this do that content access does not provide?

jherencia’s picture

jherencia commented

@klausi I've fixed that minor issue too.

@nevets They are modules for different purposes. I can't disable /node path with content access module, I can disable visibility of nodes of a certain type in both /node and /node/[nid], but not just for /node.

jherencia’s picture

jherencia commented
Status: Needs review » Reviewed & tested by the community
klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented

Don't set your own issues to RTBC. However, I still think your module is justified, so I leave it as is.

jherencia’s picture

jherencia commented

Ups, sorry I thought the reasons were clear enough after my post, didn't know I should't change the status.

Thank you.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Reviewed & tested by the community » Fixed

@nevets at first I didn't understand this module and agreed with your perspective, however reading the project page it became more clear. This is about the "/node" page which lists all nodes promoted to the homepage on the site.

Thanks for your contribution, jherencia! Welcome to the community of project contributors on drupal.org.

I've granted you the git vetted user role which will let you promote this to a full project and also create new projects as either sandbox or "full" projects depending on which you feel is best.

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

Fixed git instructions.