Line 279 of uc_salesforce/uc_sf_order/uc_sf_order.module this static variable is not defined anywhere, i grepped through the code and could not see a definition, also checked the salesforce module and no definition there either

Does not exist in current salesforce module 6.x-dev either

Comments

EvanDonovan’s picture

EvanDonovan commented

It's supposed to be a constant defining a required field. I looked in the Salesforce module just now, though, and you are correct, it no longer exists in there. I think it did in the past, or else it wouldn't be in this module.

Also, this field isn't required for Opportunities, so it shouldn't be defined as such in any case.

Just pushed a fix: http://drupalcode.org/project/uc_salesforce.git/commit/7031719

EvanDonovan’s picture

EvanDonovan commented
Status: Active » Fixed
dgtlmoon’s picture

dgtlmoon commented

great!

EvanDonovan’s picture

EvanDonovan commented

As for your other issues, I didn't have time to look at them more today (I take Sundays off from coding - one day of rest a week...), but I will try to address them soon. Thanks for posting.

dgtlmoon’s picture

dgtlmoon commented

no problems.

theres a few small issues with this module that when cleaned up, i think will help a lot! add me as a maintainer if you like too

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.