Add a facebook sharing link to the Settings and links. I actually added one and tested it; it seems to work. It required adding an "onclick" javascript piece to the links as they output, but I made the new argument to theme_service_links_build_link NULL by default. Here's a patch for it (with "diff -Naur service_links.module.orig service_links.module").
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | Person.jpg | 12.71 KB | akash47 |
| #4 | service_links_facebook.patch | 1.64 KB | quicksketch |
| #3 | facebook5.patch | 1.59 KB | quicksketch |
| #2 | facebook47.patch | 1.61 KB | quicksketch |
| service_links.module_2.patch | 3.11 KB | znation |
Comments
Comment #1
quicksketchThis functionality should definately be included as part of the service_links module. I don't think it's necessary to add the onclick handler though. All it does is open the link in a new window. This functionality should be applied to all service links equally, not just to the facebook link.
Comment #2
quicksketchAttached is a no-javascript version for 4.7
Comment #3
quicksketchAnd a separate patch for 5.
The icon for facebook should be: http://static.ak.facebook.com/images/share/facebook_share_icon.gif, renamed as 'facebook.gif'
Comment #4
quicksketchNew patch applies to HEAD. Moves Facebook link to a more reasonable location and uses a png image instead of gif.
Comment #5
robloachAlready in there.
Comment #7
akash47 commentedComment #8
akash47 commented