Facebook sharing link
znation - March 14, 2007 - 08:50
| Project: | Service links |
| Version: | HEAD |
| Component: | Code |
| Category: | feature request |
| Priority: | minor |
| Assigned: | Unassigned |
| Status: | patch (code needs review) |
Description
Add a facebook sharing link to the Settings and links. I actually added one and tested it; it seems to work. It required adding an "onclick" javascript piece to the links as they output, but I made the new argument to theme_service_links_build_link NULL by default. Here's a patch for it (with "diff -Naur service_links.module.orig service_links.module").
| Attachment | Size |
|---|---|
| service_links.module_2.patch | 3.11 KB |
#1
This functionality should definately be included as part of the service_links module. I don't think it's necessary to add the onclick handler though. All it does is open the link in a new window. This functionality should be applied to all service links equally, not just to the facebook link.
#2
Attached is a no-javascript version for 4.7
#3
And a separate patch for 5.
The icon for facebook should be: http://static.ak.facebook.com/images/share/facebook_share_icon.gif, renamed as 'facebook.gif'
#4
New patch applies to HEAD. Moves Facebook link to a more reasonable location and uses a png image instead of gif.