Add a facebook sharing link to the Settings and links. I actually added one and tested it; it seems to work. It required adding an "onclick" javascript piece to the links as they output, but I made the new argument to theme_service_links_build_link NULL by default. Here's a patch for it (with "diff -Naur service_links.module.orig service_links.module").

Comments

quicksketch’s picture

Status: Needs review » Needs work

This functionality should definately be included as part of the service_links module. I don't think it's necessary to add the onclick handler though. All it does is open the link in a new window. This functionality should be applied to all service links equally, not just to the facebook link.

quicksketch’s picture

StatusFileSize
new1.61 KB

Attached is a no-javascript version for 4.7

quicksketch’s picture

Version: 4.7.x-1.x-dev » master
Status: Needs work » Needs review
StatusFileSize
new1.59 KB

And a separate patch for 5.

The icon for facebook should be: http://static.ak.facebook.com/images/share/facebook_share_icon.gif, renamed as 'facebook.gif'

quicksketch’s picture

StatusFileSize
new1.64 KB

New patch applies to HEAD. Moves Facebook link to a more reasonable location and uses a png image instead of gif.

robloach’s picture

Status: Needs review » Fixed

Already in there.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

akash47’s picture

StatusFileSize
new12.71 KB
akash47’s picture