Don't set max_execution_time to a lower value than server setting

Posted by msonnabaum on September 12, 2011 at 3:36pm

4 followers

Issue Summary

The current logic that determines whether or not to set the max_execution to 240 only checks that the current value is less than 240.

Since 0 is less than 240, max_execution gets set. Problem is, 0 means infinite so max_execution gets set unnecessarily.

Attached patch fixes.

Attachment	Size	Status	Test result	Operations
fix_max_execution_time.patch	529 bytes	Idle	FAILED: [[SimpleTest]]: [MySQL] 8 pass(es), 0 fail(s), and 1 exception(es).	View details \| Re-test

Posted by adamdicarlo on November 14, 2011 at 10:49pm

Status:

active

» needs work

+++ b/drupal_queue.moduleundefined
@@ -38,7 +38,8 @@ function drupal_queue_cron_run() {
+  $max_execution = ini_get('max_execution_time');
+  if ($max_execution_time > 0 && $max_execution_time < 240 && !ini_get('safe_mode')) {

Looks like a major bug in variable use:
$max_execution vs.
$max_execution_time.

Posted by joshuajabbour on December 21, 2011 at 6:52pm

Title:	Don't set max_execution to a lower value	» Don't set max_execution_time to a lower value than server setting
Status:	needs work	» needs review

Updated patch fixing error in #1.

Attachment	Size	Status	Test result	Operations
1276598-fix_max_execution_time.patch	534 bytes	Idle	PASSED: [[SimpleTest]]: [MySQL] 8 pass(es).	View details \| Re-test

Posted by alexweber on April 10, 2012 at 5:20pm

Status:

needs review

» reviewed & tested by the community

Looks good to me.

Project:	Drupal Queue
Version:	6.x-1.x-dev
Component:	Code
Category:	bug report
Priority:	major
Assigned:	Unassigned
Status:	reviewed & tested by the community