uc_sf_account needs to check for active Salesforce connection prior to trying export (to avoid WSOD on connection failure) [#1276704]

[13-Sep-2011 02:38:42] PHP Fatal error:  Call to a member function upsert() on a non-object in sites/all/modules/uc_salesforce/uc_sf_account/uc_sf_account.module on line 267

Your try/except does not work for the case of undefined functions. (because $sf is FALSE due to a network issue)

  // Upsert the Contact object to Salesforce.
  try {
    $response = $sf->client->upsert('Id', array($contact), $contact_map->salesforce);
  }
  catch (Exception $e) {
    drupal_set_message(t('Error exporting order contact to Salesforce.'), 'error');
    sf_dpm($e->faultstring, 'Order contact exception');
    return FALSE;
  }

Now the question also is, does your salesforce ubercart code place the update in the Queue as designed by the salesforce integration module?

Comments

Comment #1

EvanDonovan commented 18 September 2011 at 12:05

Title:	White Screen O Death when fail to connect to SF server	» uc_sf_account needs to check for active Salesforce connection prior to trying export (to avoid WSOD on connection failure)
Category:	task	» bug

Most functions check if(!$sf). However apparently that experimental module is missing that code yet. I will add it soon.

The sf_queue module of the Salesforce Suite is still relatively unstable itself. I haven't tested it ever, and I haven't worked on integrating with it. That could be done, I think, through implementing its hooks, but that would be a separate feature request.

I'll try to fix this bug this week, unless you submit a patch sooner.