This patch provides thumbnail generation to imagefield.

Allow thumbnails size configuration on imagefield configuration page, and provides two thumbnail related components in node object imagefield arrays:

  • [thumbnailpath]: path to the thumbnail image
  • [view_thumbnail]: generated html for the thumbnail. Override it using theme_imagefield_image_thumbnail
CommentFileSizeAuthor
#7 imagefield_5.1-thumb_1.patch10.33 KBnacho.mg
imagefield.module-5.1_thumb.patch5.06 KBnacho.mg

Comments

nacho.mg’s picture

nacho.mg commented
Status: Needs review » Active
nacho.mg’s picture

nacho.mg commented
Version: 5.x-1.x-dev » 5.x-1.1
nacho.mg’s picture

nacho.mg commented
Assigned: Unassigned » nacho.mg
Category: task » feature
nacho.mg’s picture

nacho.mg commented
Status: Active » Needs review
twiik’s picture

twiik commented

It's working good, but I can't seem to change the thumbnails sizes. It's max 120x120 no matter what I do. And I can't find where the max resolutions are stored.

erlendstromsvik’s picture

erlendstromsvik commented

Line 10 in the patch file is wrong:

    list($twidth, $theight) = explode('x', str_replace('X', 'x', variable_get('thumbnail_resolution','120x120')));

You can't get widget parameters with variable_get().
Change the line to:

    list($twidth, $theight) = explode('x', str_replace('X', 'x', $field['widget']['thumbnail_resolution']));
nacho.mg’s picture

nacho.mg commented
StatusFileSize
new imagefield_5.1-thumb_1.patch10.33 KB

Totally right! Here's the patch fixed.

dopry’s picture

dopry commented
Version: 5.x-1.1 » 6.x-3.x-dev
Status: Needs review » Needs work

I did a quick once over on the code... I'm moving this to head, which is technically 5--2, I haven't made a dev release of it... I'd love to see this feature in it!! I'm recovering from a curmudgeonly phase. :)

It does needs some work still.

1) thumb_path needs to be added to the database columns, eliminating it from hook_field op=load. We need to save the path in the database at the time of thumbnail creation/image upload.

2) need to be able to configure base thumb path same as image path with token support. see the token support implementation for image_path. I would like to see the $item->thumbnailpath = tokenized($thumbpath) . tokenized($imagepath).

3) _thumbnailname needs to be imagefield_thumbnailname to keep the function in the proper namespace for the module. Adhering to your namespace is very important in Drupal, especially with many modules competing for namespace.

4) reroll against DRUPAL-5--2 branch of imagefield.

If you get the patch done. I'll get the update function.

Awesome work by the way.

--dopry

jpetso’s picture

jpetso commented

Either this issue or #152370: Thumbnail support is a duplicate. Could a maintainer please decide on one of those and close the other?

CoolDreamZ’s picture

CoolDreamZ commented

Subscribing as this is an important issue - displaying the full size images in the edit node page is a serious performance hit.

dopry’s picture

dopry commented

@trasgu: can you explain to me how this patch handles thumbnails created if the image is not save... say the user never submits the node and the original file is never really saved? I don't want to be leaving dangling thumbnails around... and I'm having braindead morning. Are you gonna get a chance to update the patch?

nacho.mg’s picture

nacho.mg commented

Sorry, I was little offside. Let me recover this patch and think about it ;-)

MPiccinato’s picture

MPiccinato commented

I am willing to support this fix financially if needed to get it done ASAP and committed to the HEAD.

ChristieLuv’s picture

ChristieLuv commented

Hi! This looks like a great patch! I haven't patched a file before, can you show me instructions on how to patch the file or just attach the already patched file? Thank you so much!

ChristieLuv’s picture

ChristieLuv commented

Oh nevermind, I found out how to do it with this page:

http://drupal.org/node/101748

The instruction are pretty much the same with the latest v5. Thank you so much though!

thepanz’s picture

thepanz commented
Assigned: nacho.mg » Unassigned

IMHO this feature don't have to build it into imagefield, let Imagecache ( http://drupal.org/project/imagecache ) do it's (fine) work. Maybe Imagecache and Imagefield can merge, or Imagecache have to add support for "Default" image..

Regards..

quicksketch’s picture

quicksketch
he/him
commented
Status: Needs work » Closed (fixed)

We've had thumbnail support in the 6 version for a while now. Please open a new issue for any enhancements to the current approach.