adjust_resolution for pie charts requires conversion [#1277380]

Carts are incorrect

For some reason the charts are not matching up with the count values. Please see attached which shows there are 198 How2 content types while there are 682 Articles... Oddly on the graph they seem to have an equal amount of the pie. It seems like it is hitting a maximum value and using that same value of How2, Article and Operational Changes.

I have tried messing around with the view but as far as I can see it is correct. I did have to patch out the pipe for a comma in order to get it working at all...

Comment	File	Size	Author
#9	chart-broken,small-slices-invisible.png	45.52 KB	gogowitsch
#9	chart-correct-as-it-should-be.png	51.77 KB	gogowitsch
#6	bad_chart.png	10.62 KB	capynet
#6	fixed_chart.png	11.71 KB	capynet
	Content Ratings - Knowledge_1315836614834.png	13.92 KB	westie

Comments

Comment #1

13rac1 commented 13 September 2011 at 18:36

Can you post the image URL?

Comment #2

13rac1 commented 14 September 2011 at 20:17

Status:

Active

» Postponed (maintainer needs more info)

Comment #3

westie commented 15 September 2011 at 08:27

Really sorry we use it on our Intranet, should I export the view?

Comment #4

13rac1 commented 15 September 2011 at 17:39

The image isn't on your intranet, it is hosted on Google servers. You can post the URL to it.

Comment #5

13rac1 commented 1 November 2011 at 21:03

Status:

Postponed (maintainer needs more info)

» Closed (cannot reproduce)

Re-open if you can supply the URL. Thanks!

Comment #6

capynet commented 22 November 2011 at 17:03

Title:	Incorrect results for the charts	» Found the problem
Component:	Views integration	» Code
Assigned:	Unassigned	» capynet
Status:	Closed (cannot reproduce)	» Reviewed & tested by the community

Status	File	Size
new	fixed_chart.png	11.71 KB
new	bad_chart.png	10.62 KB

Pie is taking values without converting they into percentages.
I made a change on the code to fix that (later i will put the patch)

For now works only in php >= 5.3

In chart.module near line 295:

   elseif ($chart['#adjust_resolution']['#adjust'] == TRUE){
      _chart_adjust_resolution($chart['#chart_id'], $chart['#data'], $chart['#adjust_resolution']['#max']);
    }
  }

//Convert data to percentage when its a pie chart
  if (in_array($chart['#type'], array(CHART_TYPE_PIE, CHART_TYPE_PIE_3D))) {
      $total = array_sum($chart['#data']);
      $chart['#data'] = array_map(function($number) use ($total) {
              return number_format($number / $total * 100, 1);
          }, $chart['#data']);
  }

Comment #7

13rac1 commented 22 November 2011 at 17:16

Title:	Found the problem	» Incorrect results for the charts
Status:	Reviewed & tested by the community	» Active

Please use a descriptive title and status. Setting title back.

Comment #8

capynet commented 22 November 2011 at 19:21

Sorry. its my first time and not realized I had changed the status of the issue

Comment #9

gogowitsch commented 23 November 2011 at 21:20

Status	File	Size
new	chart-correct-as-it-should-be.png	51.77 KB
new	chart-broken,small-slices-invisible.png	45.52 KB

There seems to be a problem in the #adjust_resolution code, which the support charting module is using: small numbers seem to be rounded to zero (see attached images)