Donations module forces tags in HTML output, but only for the donation module block as all other blocks and modules are fine.

If these centering was done in the CSS I could easily fix the issue but this appears to be embedded in some template code that I cannot find.

How do I remove the addition of these center tags in the HTML output?

I am running Drupal 5.1 and the Chameleon/Marvin theme.
Here is the code that outputs for my homepage:

<div class="block block-donations" id="block-donations-0">
 <h2 class="title">Donations</h2>
 <div class="content"><center>text about the donation goes here.<br /><br /><a href="http://donorge.org/d_donate/basket_add/0/1/1" target="_blank"><img src="http://donorge.org/graphics/buttons/donorge_b1.gif" alt=Donate border="0"></a><br /><a href="/madison/donations/item_latest/1" title="">donations</a></center></div>
</div>

Also, while I'm on the topic, why is the text link in the code above for "donations" presented as an image? Other issues I have with the donations block are listed as follows:

* HTML output is not compliant (i.e.: alt=Donate should output as alt="Donate")
* HTML output is not compliant (i.e.: title="" should output as title="Latest Donations")
* Donorge.org's server is not functioning so the module doe snot work. When will this service be back online?

Thank you for the help,
_rs

Comments

blakehall’s picture

blakehall commented
Title: Donations module forces <center> tags in HTML output » Fix:
Status: Postponed (maintainer needs more info) » Needs review

All that's needed is to remove the <center> tags from $block['content'] on line 891 (of version 5.x-1.x).

I'm not quite sure why the module would include these tags, but seems like such a trivial fix a patch would be pointless...

(changing status to code needs review to hopefully catch the maintainers attention)

blakehall’s picture

blakehall commented
Title: Fix: » Why are there <center> tags in .module file for donations block?

changing title back to something that makes sense...

(oops)

lapurd’s picture

lapurd commented

Hi hello,

I maintain this module and orginally created it for Drupal 4.5 I believe it was (which was never uploaded). The reason for the forced tags and all that stuff, I think pretty much is because the theming code in Drupal never was something I partically was fond of and way back I simply hard coded the tags just so that it worked. So this was hard coded in the module and the 'center' tag, I suppose, is a left-over from a time where it might have been good to use. Anyway, Drupal 5 has much better theming and as mentioned in the module comments (on top), the module should start to support Drupal 5 theming and rid of the old tag stuff.

So removing the center tag is no problem, there is no real reason for it to be there (anymore). I'll remove it in the module but as 'blakehall' explained, it's a trivial fix.

As for your problems with the theming of the block, I am not sure I understand your problem. Still, looking at your pasted html code, it seems Drupal 5, or Chameleon/Marvin, formats the block in a way that I was not aware of. I have always been confused by Drupal's theming stuff since there seem several solutions and I never really invested time to figure out if it is at all possible for a developer to just provide some code and be guaranteed it keeps working in future releases. My point/question is basically, if I fix it for Chameleon/Marvin, then can I expect others to have problems if they use another theming system?

With regards to the HTML compliant code, I'll fix that so it is compliant as per your suggestions.

As for the Donorge service being offline, well, that's really the biggest problem here. Donorge costs me money, more then I get for it and I simply don't have the money to keep it on-line at the moment. To top it off, some people are quick to call me names when something isn't going fast enough for them, so it's making me question why I run this service at all. Really, I have no money to run this service and people have few or no money to make donations in first place. I'd really like to put it on-line right now, but I can't pay my bills. This in turn makes it pointless for me to work on the module or the new Donorge codebase and pretty much drags me to the ground. I don't really like this anymore if you get my point.

mishhh’s picture

mishhh commented
Title: Why are there <center> tags in .module file for donations block? » About the last statement regarding donorge being offline

Instead of keeping the site offline, maybe it should be better to show a page with "donate for donorge.org". Maybe it will help. Afterwards, if it functions, this page should transform into a section on the first page staying there always with a history of donations attached to it.

I'm new to donorge and I don't know its past, but I've looked into it a phew months ago while the site was up and running.

Maybe what I'm talking about here was already implemented, I don't know.

I don't know how donorge really functions, but a small fraction from every donation, say 1%, it's not the end of the world....

mishhh’s picture

mishhh commented
Title: About the last statement regarding donorge being offline » Why are there <center> tags in .module file for donations block?

I've changed the title of this issue by mistake. I hope it is ok now.

lapurd’s picture

lapurd commented

When Donorge started a few years ago, it took a small percentage of each donation as you just suggested. The main problem with this, or with Donorge, is that it relies upon a payment portal, or banks and that way you end up with fees applied upon fees and that quickly adds up. Quite a few people complained about Donorge adding a fee upon PayPal etc. I could not blame them, altough at some point Donorge has to make up it's mind. Perhaps Donorge could use a activation fee where for each item you first pay a small fee. I also have been thinking about selling stuff via Donorge and using the percentages for supporting items. Sort of like a charity shop, altough for this Donorge would need to become like a shop and I am not sure about that either and would a clear financial support from many people. Also, while you can depend on donations every now and then, as soon as you need to be a consistent financial service, you cannot expect donations to be your working model.

mishhh’s picture

mishhh commented

I'm quite ignorant about the workings behind donorge.
But my logic says that, if there are extra payments, they should be distributed to all registered users who received money in that month. Anyone who received donations would have to cover these extra payments in a percentage manner.

I don't think there is someone who can says no about it, because it is more than fair.

The problem is that a system must be implemented to extract % of donations in a month for the payments you are talking about.
But after this, everything will fall in place (if donations will appear).

Project: » Lost & found issues

This issue’s project has disappeared. Most likely, it was a sandbox project, which can be deleted by its maintainer. See the Lost & found issues project page for more details. (The missing project ID was 16484)