When processing hierarchies, items are copied to their parents as children and then stripped from the top level. In other words, it is a two-step nesting process. The function that strips the children form the top level (i.e. step 2) is currently named facetapi_filter_inactive_parent() which is not reflective of what it actually does. The function should be renamed and documented to it is more transparent as to what it is actually doing.

CommentFileSizeAuthor
#1 facetapi-1278084-1.patch1.55 KBcpliakas

Comments

cpliakas’s picture

Status: Active » Needs review
StatusFileSize
new1.55 KB

The attached patch makes the change for transparency as to what that function is actually doing.

cpliakas’s picture

Status: Needs review » Fixed

Automatically closed -- issue fixed for 2 weeks with no activity.