This is very similar to #1263884: Avoid redirect field and form injection on entities that have a path but where this makes no sense (like comments).
When using a field_collection as provided by http://drupal.org/project/field_collection,
a vertical tabs is provided for each field_collection entity within the node.
That in itself is bad, but worse, when saving the node, the custom Meta tag data for the node is not saved.

If a fix similar to that provided for the redirect module could be found, that would be great.

CommentFileSizeAuthor
#1 1278794-i-dislike-field-collection-and-vertical-tabs.patch949 bytesdave reid

Comments

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
StatusFileSize
new 1278794-i-dislike-field-collection-and-vertical-tabs.patch949 bytes

I would like to try and alternative approach where we check if there is actually a vertical tab element in $form. If this works for you I want to use the same approach in redirect as well.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Active » Needs review
dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

The alternative is that we add 'metatags' => FALSE to field_collection_entity_info().

alanburke’s picture

alanburke commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.
Patch applies, vertical tabs only show the one needed for the node itself.
Dave Reid - you're something special.
Gentleman, genius, insomniac.
[And maybe you'll grow to love field_collection in the future too!]

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Reviewed & tested by the community » Fixed

Committed #1 to Git.
http://drupalcode.org/project/metatags.git/commit/8f7fa2e

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.