My site has 3000+ registered user and subscribe to this module. The problem is, it can produce user list in administration since it will end with memory limit. Some site may limit their user to change memory limit value.
Even though I have increase my memory limit up to 512MB, time for generating the list quite long. Sometimes it can cause trouble because of high server load when Drupal need to process 3000+ list. So here, i provide one solution by adding pagination with limit 100.
ps: I create this patch from -dev version. Have been tested with this patch applied http://drupal.org/node/365700#comment-4985280, shows no problem. Kindly to report to me again. When #365700: Need to queue mailings across multiple cron runs for scalability have been committed, i will create new patch based on it.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | 1278816-rerroll-5.patch | 125 KB | larisse |
| notify-add-pagination.patch | 1.37 KB | parasolx |
Comments
Comment #1
gisleFeature requests go in the latest version.
The patch nay need to be rerolled for Drupal 8.x-1.x.
Comment #2
vuilComment #3
gisleFeature requests go in the latest version.
Patch need to be reviewed by the community.
The patch may also need to be reolled for Drupal 2.0.x.
Comment #4
larisse commentedI'll make a reroll the patch for Drupal 2.0.x
Comment #5
larisse commentedComment #6
gisleThe patch does not apply against 2.0.x-dev. I get these errors:
Checking patch README.txt...
error: patch failed: README.txt:1
error: README.txt: patch does not apply
Checking patch config/install/notify.settings.yml...
Checking patch config/schema/notify.schema.yml...
Checking patch notify.info...
Checking patch notify.info.yml...
Checking patch notify.install...
Checking patch notify.links.menu.yml...
Checking patch notify.links.task.yml...
Checking patch notify.module...
Checking patch notify.permissions.yml...
Checking patch notify.routing.yml...
Checking patch src/Access/UserSettingsAccess.php...
Checking patch src/Form/DefaultForm.php...
Checking patch src/Form/QueueForm.php...
Checking patch src/Form/SettingsForm.php...
Checking patch src/Form/SkipForm.php...
error: patch failed: src/Form/SkipForm.php:1
error: src/Form/SkipForm.php: patch does not apply
Checking patch src/Form/UserSettings.php...
error: patch failed: src/Form/UserSettings.php:1
error: src/Form/UserSettings.php: patch does not apply
Checking patch src/Form/UsersForm.php...
namespace Drupal\notify\Form;
error: patch failed: src/Form/UsersForm.php:1
error: src/Form/UsersForm.php: patch does not apply
Checking patch tests/src/Functional/LoadTest.php...
Checking patch tests/src/Functional/NotifyUITest.php...
Also, the original patch by parasolx changed around 8 lines of code in a single file. The reroll changes around 2700 lines in 20 files, including README.txt and a lot of other files that do not need changes in order to add a pager to the user list.
I am trying to figure out what this patch is supposed to do, and to me, it looks as if it somehow tries to recreate a Drupal 6 version of the project (with pagination added) from the latest D8/9 version. That is not what is wanted.
What is wanted is to have pagination on the user page for the D8/9 version.