I do get the notice below when I delete a user.

Notice: Undefined variable: uid in workbench_access_user_delete() (line 1032 of workbench_access.module).

The attached patch fixes this.

CommentFileSizeAuthor
#5 1278986-php-notice-workbench-access-user-delete.patch1.06 KBdave reid
#4 1278986-fail.patch641 bytesdave reid
undefined-variable.patch441 byteslarskleiner

Comments

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Active » Reviewed & tested by the community

Looks good.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Reviewed & tested by the community » Needs review

Actually we should add a test on user delete.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Assigned: Unassigned » dave reid

Assigning to myself.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
StatusFileSize
new 1278986-fail.patch641 bytes

Attached test without the fix to workbench_access.module should fail.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
StatusFileSize
new 1278986-php-notice-workbench-access-user-delete.patch1.06 KB

And the cumulative patch should be ready to go.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs review » Fixed

Committed #5 to Git.
http://drupalcode.org/project/workbench_access.git/commit/7788949

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.