Download & Extend

Migrated fields lose 'required' setting

Project:Content Construction Kit (CCK)
Version:7.x-2.x-dev
Component:upgrade path
Category:bug report
Priority:major
Assigned:Unassigned
Status:reviewed & tested by the community

Issue Summary

After migration none of my fields are set to required any longer. This patch fixes it, but I think there might be more to this bug- I'm not sure about _content_migrate_get_instance_values - it looks the problem may be just above my patch:

<?php
// Pass field settings to the instance, in case they are needed.
     
$field_value = array(
       
'require' => $instance_value['required'],
       
'type' => $instance_value['type'],
       
'module' => $instance_value['module'],
       
'settings' => unserialize($instance_value['global_settings']),
      );
?>

i.e., if we're passing field settings to the instance, shouldn't it be $instance_value = array( ... ? $field_value variable seems to be quickly forgotten after this.

AttachmentSize
cck-required.patch1.07 KB

Comments

#1

This patch appears to work for me. Thanks!

#2

This patch wasn't applying cleanly for me using Drush Make, so I've tried re-creating it.

AttachmentSize
cck-7.x-dev-required.patch 868 bytes

#3

consistently reproducible
patch appears to work
should we increase priority to major ?

#4

Priority:normal» major

should I take the responsibility to mark this RTBC ?

#5

Status:needs review» reviewed & tested by the community

It works. And I don't see any side effect.