USASearch

Hi adam_at_mobomo,

I created a couple issues in the project issue queue. Please set this status back to "need review" when those are fixed.

I've created a similar module from example code provided to me by the USASearch team (Erik). My module takes a slightly different approach with the default search page/paths. I was going to create my own project today but I noticed the module namespace was taken when I tried to submit my project. What's the best way to proceed?

Thanks, Tim

Hi timwood,

Ideally you'd work together with adam_at_mobomo on a single implementation. adam_at_mobomo hasn't responded in over a month, so may no longer be available to collaborate, in which case you should just go ahead with your own project. Either way, the first step is creating a sandbox project. Anyone can create sandbox projects, without any approval. Your sandbox project will either become the full project, or give adam_at_mobomo somewhere to look at your code so you can collaborate.

I'm not sure what you mean by "the module namespace was taken." There shouldn't be any namespace check on sandbox projects. There is a check on full projects, but it doesn't look like you have access to create full projects yet, and also http://drupal.org/project/usasearch seems to be available. Maybe that's just a misleading error message? If you've agreed to the Git terms in your profile and you're unable to create a project, I suggest opening an issue in the webmasters queue, and someone there can help track down the problem.

sreynen,
Adam and I are working on combining our code and cleaning up the project. He has given me git access and we are discussing how to merge our code via email.

As for my "module namespace" comment, I get an error on the create project page when I tried to submit my project title as "USASearch". As I can only create sandbox projects, this was checked by default. I assumed because Adam's sandbox was called "USASearch" D.O. was not allowing me to create my sandbox with the same name/title. If this doesn't sound correct, let me know and I'll open an issue in the webmaster queue as you suggest.

Thanks!

It's great to hear you're collaborating. I hope that proves a fruitful relationship. I'm going to change the status on this to "postponed" for now. Please change it back to "needs review" as soon as you have a combined project you're ready to publish as a full project.

On the name check thing, I just had no idea that check existed. I'm sure that's intentional, so not worth opening an issue unless you feel strongly there shouldn't be a check on that.

I'd be interested as a beta tester if you need one...

Thanks for the offer, jasonh!

Any and all testers are welcome. To checkout the 2.x code I committed use:
git clone --branch 6.x-2.x http://git.drupal.org/sandbox/adam_at_mobomo/1271006.git usasearch

Thanks

After much offline discussion with Adam I've committed what I believe will be the initial release version of the module. It's still in the 2.x branch at:
git clone --branch 6.x-2.x http://git.drupal.org/sandbox/adam_at_mobomo/1271006.git usasearch

I've fixed and close the issues created in the module queue by sreynen, made lots of improvements and ran the code through the coder module and fixed issues it identified.

Please review the module code, module page, etc. again.

Thanks!

Raising the priority since it's almost been 2 weeks since flagged as needs review. Anyone have time to review? Pretty please. ;-)

I'm very sorry for the delay, the queue is quite long at the moment and there are only a few reviewers,
please think about helping us!

lets start with an automated one:
There are still files other than README.txt in the master branch, make sure to remove them. See also step 5 in http://drupal.org/node/1127732

Review of the 6.x-2.x branch:

• ./usasearch.module: all functions should be prefixed with your module/theme name to avoid name clashes. See http://drupal.org/node/318#naming
  

  function redirect_to_usasearch($query = '') {
  

• Drupal Code Sniffer has found some code style issues (please check the Drupal coding standards). See http://ventral.org/pareview/httpgitdrupalorgsandboxadamatmobomo1271006git.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner.

Thanks for reviewing patrickd! And thanks for your awesome PAReview script on Ventral.org!

Adam has fixed the issue with the master branch, moving his code to a 6.x-1.x branch. There will be no release of this branch once the module is approved. Should we remove the branch or keep it for historical purposes?

For the 6.x-2.x branch, I've fixed the namespace issue in that function and corrected all the coding standard errors. I didn't fix any of the "line exceeds 80 characters" warnings, hope this is okay.

Please review again when you have time and I'll attempt to review some other project applications to get a review bonus.

Both adam_at_mobomo and timwood should be granted contributor privileges.

• They have collaborated together
• They have been responsive and considerate to adhere to the community standards
• They have worked together on an issue queue

You guys are model contributors!

The code sniffer brings back some things, but they're minor and shouldn't be a blocker. You shouldn't concatenate translatable strings. Use the variables available in t(), which will also make the translator's life a lot easier. Also, when doing in-line if statements ($var = statement ? TRUE : FALSE) the ? and : should have spaces. Totally minor, and not an application blocker.

Your code looks really good, and you've used the hook system well. And you're right, its good to think about how to overlay a new feature and making it easy on site builders. You definitely have a good sense of how to work with Drupal well.

Congrats, and I hope you guys do some more great work.

Congratulations timwood, adam_at_mobomo you are both vetted git users now. Awesome to see collaboration. Thank you patrickd for your always-solid reviews, sreynen for your great constructive input, and ceardach for bringing this home (after more than a month and a half, sorry Tim and Adam!)

Looks like a great module and looking forward to your continued responsiveness and improvements!

THANK YOU! Thanks to patrickd, ceardach and mlncn for taking the time to review and approve the project.

I will look into ceardach's coding suggestions and create an issue on the project's queue to get those items fixed.

-Tim