Bar charts are not displayed because of missing $base_path in URLs.

Solution is to prefix drupal_get_path() with $base_path when used to build URLs:

- $path = url(drupal_get_path('module', 'tablemanager'));
+ $path = (base_path() . drupal_get_path('module', 'tablemanager'));

Tormi

Comments

pobster’s picture

pobster CreditAttribution: pobster commented

Ah ha! Well spotted! Mind you, your reasons are slightly incorrect ;o) It's not that the base_url isn't present as it is (Drupal call 'url' http://api.drupal.org/api/5/function/url does indeed allow for this), the problem is that if you're not using clean urls then the url returned is a query string such as www.yoursite.com/basepath/?q=modules/tablemanager/misc/somecolor.png. I know this as the test site I knocked up to test this new version on requires a base_url and Tablemanager worked just fine when I tested it because I always use clean urls!

Anyways, thanks for spotting it/ fixing it - I'll roll a new release asap.

Pobster

tormi’s picture

tormi
Primary language Estonian
Location Tallinn
CreditAttribution: tormi commented

the problem is that if you're not using clean urls..

It's Drupal's default setting not to use clean urls, IMHO we should always test against it;)

Anyway, thanks for the prompt answer.

Tormi

pobster’s picture

pobster CreditAttribution: pobster commented
Status: Needs review » Closed (fixed)
tormi’s picture

tormi
Primary language Estonian
Location Tallinn
CreditAttribution: tormi commented

Seems like You missed one case at function tablemanager_css() in commit 1.87 (DRUPAL-5--1-4)

Tormi

pobster’s picture

pobster CreditAttribution: pobster commented

Yeah I realized after I'd already committed it (when I was updating the 4.7 release - which got updated correctly!)

I guess it's not a huge issue, I'll just update it next release.

Thanks for pointing it out though :o) Nice to know there's a community behind me!

Pobster