Hi there,

thanks for the module - I'm attaching a patch that allows any/all roles to be referenced if none are explicitly selected when configuring the field. I'm marking this as a bug report instead of a feature request only because I don't see the use case for configuring a field that doesn't allow a selection...

thanks!

Adrian

CommentFileSizeAuthor
#3 1280532_all_roles.patch912 bytesmrharolda
rolereference_allroles.patch1.13 KBacrollet

Comments

johnv’s picture

johnv
Primary language Dutch
commented
Status: Needs review » Reviewed & tested by the community

This works fine..

jantimon’s picture

jantimon commented

Same here - thanks for the patch.

mrharolda’s picture

mrharolda commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new 1280532_all_roles.patch912 bytes

Here's a simplified version of Adrian's patch (also rolled on the current git version of rr). Iterating $user_roles is not needed if the result is just a copy of it.

johnv’s picture

johnv
Primary language Dutch
commented
Status: Needs review » Reviewed & tested by the community

patch #3 is indeed shorter, and works flawlessly.

mrharolda’s picture

mrharolda commented

Any chance of commiting & releasing this? We can't store role ids in our features because they can be different on installations, depending on the order in which they are created.

This patch allows us to use a role reference field without settings any role ids.

deekayen’s picture

deekayen commented
Status: Reviewed & tested by the community » Fixed

Committed to 7.x-1.x at ad2dcb8ae5c26127d4bcfcd192592aa7df1db33e, though the patch seemed to be created against master.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.