Somehow I'm still seeing implode errors for simplefeed even though I thought it was fixed at one point. Am using the latest development version of simplefeed (simplefeed_item.module,v 1.13 2007/03/10 02:06:31) and this is what I'm seeing in the watchdog:

implode() [<a href='function.implode'>function.implode</a>]: Bad arguments. in /home/topsac/public_html/modules/contrib/simplefeed/simplefeed_item.module on line 360.

Comments

Caleb G2’s picture

Caleb G2 commented

Whoever thought of the name "implode" for that php function should have considered what that would look like as an error - to someone who didn't know better it leaves the impression that their site is about to burst into flames. (Oh, **it - my site is imploding!!!)

;)

m3avrck’s picture

m3avrck commented

I can't reproduce this, got the feed URL that is causing the problems?

Or try outputting $item->get_categories() in simplefeed_item.module and see what's in the array... junk?

Caleb G2’s picture

Caleb G2 commented

Unfortunately no, I don't have the feed url - I've got too many feeds going right now to be able to tell and the error message doesn't specify.

If you can give me a more precise string to plug into the simplefeed_item.module and a line number to place it at, I'll give it a go...

m3avrck’s picture

m3avrck commented

Line 358, right after the variable get, try this

watchdog('simplefeed', print_r($item->get_categories()), WATCHDOG_ERROR, l('view', 'node/'. $process_feed->nid));

Caleb G2’s picture

Caleb G2 commented

So I made it look like this:

if (variable_get('simplefeed_categories', 0)) {  
            if (count($item->get_categories()) > 0) {
              $tags .= ', '. implode($item->get_categories(), ', ');
              watchdog('simplefeed', print_r($item->get_categories()), WATCHDOG_ERROR, l('view', 'node/'. $process_feed->nid));
            }

And then I manually updated a feed and then went to the watchdog. The usual implode error was there and along with it was a message that simply reads, "1".

Hopefully I did this right and it means something...(?)

m3avrck’s picture

m3avrck commented

Can you past the full details? Copy/paste the code?

is it array([1] ==> 1) or something?

Caleb G2’s picture

Caleb G2 commented

Hm. There entire message was literally, "1". That's it.

Did the code I pasted in (see my previous response) seem like it was correct?

m3avrck’s picture

m3avrck commented
Status: Active » Closed (duplicate)

Doh! Seems to be me hardcoding something.

http://drupal.org/node/127374