In the metatag override pages (e.g.: admin/config/search/metatags/config/global%3Afrontpage, admin/config/search/metatags/config/node, etc.), in the Advanced fieldset, the link to the Open Directory Project in the title of the checkbox metatags[robots][value][noodp] is linked to @odp-link, not http://www.dmoz.org/.

Observed on brand-new drupal-7.22 (minimal install profile) with ctools-7.x-1.0-rc1, metatags-7.x-1.0-alpha1 (Meta tag API and Meta tag UI sub-modules enabled) and token-7.x-1.0-beta5.

Patch to follow.

CommentFileSizeAuthor
#1 fix_t_args_name-1281534-1.patch1.04 KBmparker17

Comments

mparker17’s picture

mparker17
he/him
Primary language English
Location UTC-5
commented
Status: Needs review » Active
StatusFileSize
new fix_t_args_name-1281534-1.patch1.04 KB

The argument @odp-link in the string passed to t() did not match the name of the argument passed to the same function (it was @odp-url). You'll need to clear caches after applying the patch.

mparker17’s picture

mparker17
he/him
Primary language English
Location UTC-5
commented
Version: 7.x-1.0-alpha1 »
Status: Active » Needs review

Whoops... should mark as "needs review".

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Active » Fixed

Thanks! I used @odp-url but I still gave you credit on the commit to 7.x-1.x.
http://drupalcode.org/project/metatags.git/commit/ad95fca

mparker17’s picture

mparker17
he/him
Primary language English
Location UTC-5
commented

Cool!

Thanks for all your hard work on this module! It looks awesome!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

mparker17’s picture

mparker17
he/him
Primary language English
Location UTC-5
commented
Version: » 7.x-1.x-dev
Assigned: mparker17 » Unassigned
Issue summary: View changes

Unassigning myself, now that this is Closed (fixed).