The reason for having a separate UI module was so that Acquia could use an alternative UI with Drupal Gardens when we different about the needs of the UI for Gardens vs normal users installing the module. Eventually we came to a really good compromise so I think we need to get rid of the separate module and merge it back in.

CommentFileSizeAuthor
#4 1281624-merge-metatag-ui.patch19.42 KBdave reid

Comments

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Issue tags: +D7 stable release blocker

.

willvincent’s picture

willvincent commented

From a performance and memory usage perspective, keeping it a separate sub-module might not be a horrible idea. While it's likely most people would wind up enabling both the base metatag module and the metatag_ui sub-module, in the event that configuration only needed to be set up once and then the token values set would work for the lifetime of the site, not having the UI portion built into the base module would probably decrease memory usage a bit.

Sure it's probably a negligible amount, but any amount of memory savings is probably a good thing.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

There would be very little performance and memory concerns as the code needed for the admin UI would be self-contained in metatag.admin.inc and not be loaded on normal page requests.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Version: » 7.x-1.x-dev
Status: Active » Needs review
StatusFileSize
new 1281624-merge-metatag-ui.patch19.42 KB
dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs review » Fixed

Committed #4 to Git.
http://drupalcode.org/project/metatag.git/commit/9601dd1

Automatically closed -- issue fixed for 2 weeks with no activity.