The javascript attached to the hosting site form is properly nasty!

Let's clean it up and make the fact that it's doing something more obvious.

Comments

steven jones’s picture

steven jones commented
Assigned: Unassigned » steven jones

Doing this in: dev-1282280-site-form-javascript

steven jones’s picture

steven jones commented
Assigned: steven jones » Unassigned
Status: Active » Needs review

Okay, so I've added a subtle spinner to the form in the branch. At least you know that the form is doing something now! It would be good to get some reviews before I merge it in.

steven jones’s picture

steven jones commented

Would be great to get a review of this if possible? They don't necessarily need to review the code, but rather the slight modifications to the form etc.

steven jones’s picture

steven jones commented
Status: Needs review » Fixed

Reviewed myself, and it looks good, so pushed!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 1d6dfcf on 6.x-2.x, dev-ssl-ip-allocation-refactor, dev-1205458-move_sites_out_of_platforms, 7.x-3.x, dev-588728-views-integration, dev-1403208-new_roles, dev-helmo-3.x by Steven Jones: 
    Issue #1282280 by Steven Jones: Clean up the hosting form javascript.

  • Commit 1d6dfcf on 6.x-2.x, dev-ssl-ip-allocation-refactor, dev-1205458-move_sites_out_of_platforms, 7.x-3.x, dev-588728-views-integration, dev-1403208-new_roles, dev-helmo-3.x by Steven Jones: 
    Issue #1282280 by Steven Jones: Clean up the hosting form javascript.