According the api, it looks like it should not be expecting parameters to be passed by reference.

http://api.drupal.org/api/drupal/modules--user--user.api.php/function/ho...

CommentFileSizeAuthor
#1 pass_by_value-1282564-1.patch494 bytesDeeLay

Comments

DeeLay’s picture

DeeLay commented
StatusFileSize
new pass_by_value-1282564-1.patch494 bytes

Attached patch

Isostar’s picture

Isostar commented
Version: 7.x-2.x-dev » 7.x-2.7

Still present.

Anonymous’s picture

Anonymous (not verified) commented

The error message reads "Warning: Parameter 1 to page_title_user_cancel() expected to be a reference, value given in module_invoke_all()". The function's signature doesn't match the requirement defined by hook_user_cancel().

The error is still in the dev. The patch #1 looks fine. Go commit it.

camprandall’s picture

camprandall commented
Title: Warning: Parameter 1 to page_title_user_cancel() expected to be a reference, value given in module_invoke_all() » page_title_user_cancel() has bad signature
Version: 7.x-2.7 » 7.x-2.x-dev
Priority: Minor » Normal
Status: Active » Reviewed & tested by the community

This is just to confirm that the patch fixes the problem. We're using it in production and no longer see the error.

feddovdm’s picture

feddovdm commented

Patch #1 works for me! No longer do i see the error.

Echofive’s picture

Echofive commented

Patch #1 works for me too!

Bug related in my project.
https://drupal.org/node/2027615

blasthaus’s picture

blasthaus commented
Issue summary: View changes

why is this not committed yet? it's impossible for a user to cancel without correcting this!

wzain’s picture

wzain commented

Hi all. I am new to Drupal. How do I apply this patch? Thanks.

hargobind’s picture

hargobind
he/him
Location Austin, Texas
commented
Priority: Normal » Major

Also confirming the patch in #1 works.

Escalating the issue to Major to get the attention of the module maintainers since it was RTBC 2 years ago and still has not been committed even though this module is listed as "actively maintained".

michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented

Still applies cleanly and works.

el_reverend’s picture

el_reverend commented
Issue tags: +URGENT, +add to module, +not maintained

As of 10/20/2015 (!) this is still applicable and should be added to the module. Dear @nicholasThompson or @JohnAlbin and the other maintainers. Would you please apply the patch for the rest of the community?

michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented
Issue tags: -URGENT, -add to module, -not maintained

@el_reverend: Please read the issue tag guidelines. Tags are for grouping issues, not for emphasizing your need.