When using Boron and HTML5 Tools, Boron's html.tpl.php is used.

It would be nice if Boron checked whether HTML5 Tools is installed, and use its html.tpl.php.

CommentFileSizeAuthor
#6 html5_tools_settings.png37.76 KBgrendzy

Comments

danlinn’s picture

danlinn commented
Status: Active » Postponed (maintainer needs more info)

Shouldn't the module do the check? I'm not sure a theme should include this logic.

Fidelix’s picture

Fidelix commented

It's when using Boron that we're missing the features from HTML5 Tools, not the other way around.

I think it's strange for a module which purpose is to implement HTML5 additions to:
1. Check for one specific theme (Boron) that is preventing one of it's features to work;
2. Somehow override the html.tpl.php that boron is using.

I believe it would be more simple for Boron to:
1. Check in a preprocess function if a module which complement its features is present;
2. Use this module's html.tpl.php instead of its own.

Let me know what you think.

danlinn’s picture

danlinn commented

What is Boron doing that other themes don't? Are you able to override the html.tpl.php file in other themes?

I think before we talk about which module should do what, could you explain why this needs to happen?

grendzy’s picture

grendzy commented

The function html5_tools_theme_registry_alter should already handle this. Is there some reason the registry_alter doesn't work with Boron?

Fidelix’s picture

Fidelix commented

@danlinn, these features from HTML5 Tools won't work when using ANY theme that has its own html.tpl.php:

Support for the html5shiv plugin
Support for the innershiv plugin
Support for Google Chrome Frame

So the theme would need to integrate with it to provide this support. Since boron is an HTML5 theme that has a lot of features related to HTML5, it would be natural that this integration is done.

What is Boron doing that other themes don't? Are you able to override the html.tpl.php file in other themes?

This is not a problem with boron. I did not make a bug report, but a feature request for integration with the module in question.
If the developers feel that there is no need for this, feel free to mark it as "won't fix".

However, as a themer, know that I felt the need for this integration in my last 2 projects, where I had to manually overwrite boron's html.tpl.php with the one from HTML5 Tools to make it work.

@grendzy, I don't know the answer to your question, but I'm sure I cleared the cache with "drush cc all" at least 2 times in my last 2 projects, and boron's html.tpl.php was being used instead of the one from HTML5 tools.

Thanks for the consideration.

grendzy’s picture

grendzy commented
Status: Postponed (maintainer needs more info) » Closed (works as designed)
StatusFileSize
new html5_tools_settings.png37.76 KB

After looking closer, the html5_tools is designed not to replace a theme's html.tpl.php file.

There are a few options:

  • ask the html5 tools maintainer to remove this exception or make it configurable
  • delete boron's html.tpl.php file (it's as starter theme, you're supposed to modify it)
  • Modify the html.tpl.php file in boron (or your sub theme) to suit