library for ckeditor not detected on wysiwyg config page (/admin/config/content/wysiwyg). See discussion at http://drupal.org/node/1161738, patch submitted here is: http://drupal.org/node/1161738#comment-4531230

CommentFileSizeAuthor
#1 ckeditor-not-detected-1283274-1.patch796 bytesdoka

Comments

doka’s picture

Status: Active » Needs review
StatusFileSize
new796 bytes

patch attached

twod’s picture

Component: Code » Editor - CKEditor
Status: Needs review » Postponed (maintainer needs more info)

Removing the character read limit is a waste of memory. Now it'll always read in the whole [minimized, single-line] file instead of just a few hundred characters.
Please state which versions were not detected by 7.x-2.x before this change.
I've tested CKEditor 3.6, 3.6.1 and 3.6.2 and they were all detected by Wysiwyg 7.x-2.1 without any modifications.

doka’s picture

twod’s picture

Thanks for the make file, but it doesn't work for me. (Fails to download the patch.)
From what I can tell, the relevant actions it does is to download Drupal 7.8, CKEditor 3.6.1 and Wysiwyg 7.x-2.x-dev, so I did those steps manually. I did not apply the #1 patch.

The result is still CKEditor 3.6.1.7072 being detected on admin/config/content/wysiwyg.

For an in-depth look at how CKEditor is detected, see comment #45 over at #1151804-45: WYSIWYG can't detect latest CKeditor (build 3.6). .
The character limit was changed for version 3.6 because that version introduced a lot of changes which pushed the version id further into the file. Bumping the read limit to 500 characters per line was - and still is - well enough to compensate for any code changes pushing around that version string in minor releases.

sabsbrain’s picture

I just had this problem.

In my case, WYSIWYG 7.x-2.1 not seeing the ckeditor 3.6.2.

It turned out to be a directory permission thing - the ckeditor directory came out of the zip file as permissions 700, so that only I could see it. (ie. I had rwx permission but groups and other had nothing)

I just did

chmod -R 755 ckeditor

sutharsan’s picture

For the record, I had the same behaviour with, WYSIWYG module 7.x-2.1 not seeing the ckeditor 3.6.2.
The current WYSIWYG module 7.x-2.x-dev fixes it. The fgets() read-limit of 140 chars is increased to 500 chars and it no longer breaks the string we're it looking for.
See #1143104: Newer ( 3.6.3 ) CKeditor version not detected by ckeditor.inc

twod’s picture

Wysiwyg 7.x-2.1 does detect CKEditor 3.6.2, I just tested it.
The patch in #1143104: Newer ( 3.6.3 ) CKeditor version not detected by ckeditor.inc was applied before 7.x-2.1 was released, please see the the changelog and the 7.x-2.1 tag.

sutharsan’s picture

Status: Postponed (maintainer needs more info) » Closed (works as designed)

@TwoD, you are right. Although it is only a few days ago I can not fully recall the situation. But 7.x-2.1 is working correctly.
Lets close this discussion. doka, if you have new details, feel free to re-open the issue. But for now, there is enough time spent on proving that is works as advertised.

doka’s picture

I can also confirm: Wysiwyg 7.x-2.1 works with CKEditor 3.6.2 properly.

yermandu@gmail.com’s picture

Using Wysiwyg 7.x-2.1 works with CKEditor 3.6.2 doestn work here.

I Apply the patch proposed but detectation still issue.

twod’s picture

@yermandu@gmail.com, make sure you didn't download the "Drupal Version" of CKEditor. It's packaged differently and won't be recognized by Wysiwyg since it also has the module from http://drupal.org/project/ckeditor.

We're adding a notice about this in the next Wysiwyg release.