Closed (fixed)
Project:
GELF
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
19 Sep 2011 at 07:35 UTC
Updated:
12 Apr 2012 at 22:57 UTC
Jump to comment: Most recent file
Hi,
I'm interested in using this module for Drupal 7. If I post our patch here, are you open to creating a 7.x-1.x branch?
Also, have you tested this module in production environments? Doesn't seem to be many downloads. Are there any gotchas?
Thanks,
Kim
| Comment | File | Size | Author |
|---|---|---|---|
| #14 | d7_gelf_1283574.patch | 2.07 KB | jeffsheltren |
| #13 | gelf-d7_port-1283574-13.patch | 1.83 KB | pdrake |
| #8 | d7_port-128574-8.patch | 2.33 KB | mikebell_ |
| #5 | d7_port-1283574-5.patch | 6.7 KB | pdrake |
| #4 | d7_port-1283574-4.patch | 6.28 KB | pdrake |
Comments
Comment #1
msonnabaum commentedI'd be happy to take a D7 patch. Shouldn't be too hard.
I also haven't used this yet in production, but the real work is done by the gelf php class (https://github.com/Graylog2/gelf-php), so I don't think there are many gotchas. The actual drupal code here is quite minimal.
Comment #2
cbPatch attached.
Tested successfully with a test Drupal 7 install.
Comment #3
jeffsheltren commentedThanks for the patch. I'll do a bit of testing and see about getting a D7 version going.
Comment #4
pdrake commentedAttached is a continuation of the wotk in #2 with additional D7 updates support for the latest version of php-gelf (the version which drush will download when you enable the module).
Comment #5
pdrake commentedThis version of the patch adds basic try/catch functionality to catch the two exceptions which are likely to be thrown by the php-gelf library.
Comment #6
pdrake commentedWe have had #5 operating in production for a number of weeks now. Hoping someone can review it and get a D7 development branch going before the D6 branch diverges too far, thanks.
Comment #7
jeffsheltren commentedYep, agreed. I'll get this reviewed and pull in the recent changes to 6.x-dev so we can get a current 7.x branch here shortly.
Comment #8
mikebell_ commented#5 no longer applies to latest 6 release so I've re-rolled it.
If your looking for another maintainer then I'd be more than happy to help. We'll be rolling out the D7 version of this module to quite a few sites over the next few weeks so I should have plenty of time to look after it.
Comment #9
pdrake commentedI'm happy to help maintain as well (as I've offered before). We use both the D6 and the D7 modules in production and have been for some time.
Comment #10
msonnabaum commented#8 does not look like a re-roll of #5, although IMO #5 is beyond the scope of this issue.
Can we get a patch that only changes what needs to be changed for a D6->D7 port? I'm seeing things like the menu callback getting moved around with no explanation. That and the other changes in #5 are still up for discussion, just not in this issue.
Comment #11
jeffsheltren commentedIn reply to #10, the problem is I've let this linger so long that we've added that functionality to the d6 branch already. Sorry for that, I've been terribly sick lately and left with not much time to work on this. I had actually re-rolled the patch from #5 and have it here somewhere. I'll try to get it posted here today for review. I agree we shouldn't be pulling in other changes to d7 at this point; let's start with a clean port and go from there.
Comment #12
mikebell_ commentedThanks for the replies.
The patch in #8 is a mixture of #5 and the latest commits from the drupal 6 branch. Not sure how much of it is usable by Jeff.
Comment #13
pdrake commentedHere's a patch that contains a bare minimum set of changes for D7 compatibilit. This passes D6 -> D7 module upgrade checks provided by coder_upgrade.
Comment #14
jeffsheltren commentedHere's a simplified patch based on everything here so far, but pulling out anything that's not strictly needed for the d7 port -- let's handle that stuff elsewhere. Tested locally and it works fine for me.
@pdrake, thanks for the co-maintainership offer, I think I'll take you up on that. I also like your changes proposed in #5 for gelf/gelf_message now that those classes are separate in gelf_php. Let's follow up on that in another ticket and we can adjust 6.x as well.
Comment #15
jeffsheltren commentedOoops, I just missed #13. I'll review that now! Disregard my patch in #14 for the time being
Comment #16
jeffsheltren commentedPatch in #13 looks great to me, and I prefer your approach there to keep the GELF settings in the already existing logging settings form. I'll create a new d7 branch and push that to start with.
Comment #17
mikebell_ commentedYup all working here as well. Looking forward to seeing a 7 release.
Comment #18
jeffsheltren commentedThe 7.x-1.x-dev release is now available on the project page. Thanks everyone!
Comment #19
cbAwesome work, thanks!