Hi,

I'm interested in using this module for Drupal 7. If I post our patch here, are you open to creating a 7.x-1.x branch?

Also, have you tested this module in production environments? Doesn't seem to be many downloads. Are there any gotchas?

Thanks,

Kim

Comments

msonnabaum’s picture

I'd be happy to take a D7 patch. Shouldn't be too hard.

I also haven't used this yet in production, but the real work is done by the gelf php class (https://github.com/Graylog2/gelf-php), so I don't think there are many gotchas. The actual drupal code here is quite minimal.

cb’s picture

StatusFileSize
new4.37 KB

Patch attached.

Tested successfully with a test Drupal 7 install.

jeffsheltren’s picture

Assigned: Unassigned » jeffsheltren
Status: Active » Needs review

Thanks for the patch. I'll do a bit of testing and see about getting a D7 version going.

pdrake’s picture

StatusFileSize
new6.28 KB

Attached is a continuation of the wotk in #2 with additional D7 updates support for the latest version of php-gelf (the version which drush will download when you enable the module).

pdrake’s picture

StatusFileSize
new6.7 KB

This version of the patch adds basic try/catch functionality to catch the two exceptions which are likely to be thrown by the php-gelf library.

pdrake’s picture

We have had #5 operating in production for a number of weeks now. Hoping someone can review it and get a D7 development branch going before the D6 branch diverges too far, thanks.

jeffsheltren’s picture

Yep, agreed. I'll get this reviewed and pull in the recent changes to 6.x-dev so we can get a current 7.x branch here shortly.

mikebell_’s picture

StatusFileSize
new2.33 KB

#5 no longer applies to latest 6 release so I've re-rolled it.

If your looking for another maintainer then I'd be more than happy to help. We'll be rolling out the D7 version of this module to quite a few sites over the next few weeks so I should have plenty of time to look after it.

pdrake’s picture

I'm happy to help maintain as well (as I've offered before). We use both the D6 and the D7 modules in production and have been for some time.

msonnabaum’s picture

Status: Needs review » Needs work

#8 does not look like a re-roll of #5, although IMO #5 is beyond the scope of this issue.

Can we get a patch that only changes what needs to be changed for a D6->D7 port? I'm seeing things like the menu callback getting moved around with no explanation. That and the other changes in #5 are still up for discussion, just not in this issue.

jeffsheltren’s picture

In reply to #10, the problem is I've let this linger so long that we've added that functionality to the d6 branch already. Sorry for that, I've been terribly sick lately and left with not much time to work on this. I had actually re-rolled the patch from #5 and have it here somewhere. I'll try to get it posted here today for review. I agree we shouldn't be pulling in other changes to d7 at this point; let's start with a clean port and go from there.

mikebell_’s picture

Thanks for the replies.

The patch in #8 is a mixture of #5 and the latest commits from the drupal 6 branch. Not sure how much of it is usable by Jeff.

pdrake’s picture

Status: Needs work » Needs review
StatusFileSize
new1.83 KB

Here's a patch that contains a bare minimum set of changes for D7 compatibilit. This passes D6 -> D7 module upgrade checks provided by coder_upgrade.

jeffsheltren’s picture

StatusFileSize
new2.07 KB

Here's a simplified patch based on everything here so far, but pulling out anything that's not strictly needed for the d7 port -- let's handle that stuff elsewhere. Tested locally and it works fine for me.

@pdrake, thanks for the co-maintainership offer, I think I'll take you up on that. I also like your changes proposed in #5 for gelf/gelf_message now that those classes are separate in gelf_php. Let's follow up on that in another ticket and we can adjust 6.x as well.

jeffsheltren’s picture

Ooops, I just missed #13. I'll review that now! Disregard my patch in #14 for the time being

jeffsheltren’s picture

Status: Needs review » Reviewed & tested by the community

Patch in #13 looks great to me, and I prefer your approach there to keep the GELF settings in the already existing logging settings form. I'll create a new d7 branch and push that to start with.

mikebell_’s picture

Yup all working here as well. Looking forward to seeing a 7 release.

jeffsheltren’s picture

Version: 6.x-1.x-dev » 7.x-1.x-dev
Status: Reviewed & tested by the community » Closed (fixed)

The 7.x-1.x-dev release is now available on the project page. Thanks everyone!

cb’s picture

Awesome work, thanks!