Possible confusion over the Status message after submit.
| Project: | Revision Moderation |
| Version: | 5.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | minor |
| Assigned: | Unassigned |
| Status: | active |
Jump to:
While testing the module, a peon user edits a node, makes their revision and this is the status message:
* The menu item Testing has been updated.
* Your changes have been submitted for moderation.
<b> * The Page has been updated.</b>Mr Peon, then decides to be more productive before the admin user had a chance to approve any revisions yet. Peon goes back and edits the same node edited earlier and makes some more changes. Pressing save shows this status:
* Editing your latest revision, which is still pending moderation.
* The menu item Testing has been updated.
* Your changes have been submitted for moderation.
<b> * The Page has been updated.</b>Now lets discuss this:
1) The message "* The Page has been updated." is a minor bug and shouldn't be displayed. It gives the illusion the changes went live, when in fact its not. It also contradicts the message above it about it being submitted for moderation. So this needs to be removed I think?
2) I don't understand the thinking behind "* Editing your latest revision, which is still pending moderation." because according to the revision queue and using the diff patch, the updated revision didn't use the old (unmoderated) revision at all, since Peon started with the "current live" again when making the changes. So is this supposed to overwrite the previously submitted revision, or use the previously submitted revision in the Edit mode? Because at the moment, this is not the case.
I hope this is making sense, it's Friday so I am excused :)
#1
a) The page updated message is coming from node.module, which I didn't think I could do anything about, but I just asked in #drupal and apparently I can unset it in the $_SESSION variable. need to look into that.
b) When the user clicked edit, they should've received been editng the already edited version of their post that's pending moderation.
For example, say the text of the thing was:
"Hello"
I'm a peon, I edit it to say:
"hello world"
Publically, the post should still say "Hello". But when I click edit again, the module should see that my user already has pending revisions and load the "hello world" text.
If that's not happening, that's a bug.
#2
um, wow. that was almost a sentence. ;)
Let's try that again:
b) When the user clicked 'edit' again after having their revision in moderation, the form should have been pre-filled with the version of their post that's pending moderation, not the version that's showing publicly.
#3
a) Glad to see there's still some polishing to be done to this wonderful module.
b) That's what I though. with that in mind, I'll look again when I get back to the office on Monday and closely analyse whether its editing the node that was previously edited by the peon user or not.
Stay tuned till then ;)
#4
Webchick, b works as advertised :)
#5
Found another one to add to the list:
1) The admin moderation is disabled in Revision Moderation admin settings.
2) As admin user, edit an existing node (revision permissions etc all applied correctly). Untick the "Create new revision" but leave the Revision moderation tickbox checked in the node's Workflow options and press submit.
You'll see this:
Your changes have been submitted for moderation.The Page has been updated.
Another case of contradiction here. The node was updated, the content is live and there's nothing in the moderation queue which is correct. So the Update message status is misleading and should be omitted in this instance.