The number of tasks displayed is hidden

scor - March 16, 2007 - 20:41
Project:Tasklist
Version:HEAD
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Description

What is the purpose of this CSS rule ?

#tasks-view-filter-form label {
margin-bottom:-1.6em;
}

It hides the Showing 14 tasks. Filter: line.

#1

moonray - March 19, 2007 - 14:57

What browser are you using? On firefox it removes the extra space between the label and the select box.

#2

scor - March 19, 2007 - 19:48

Ok, it's because of my theme.
I think that instead of using

#tasks-view-filter-form label {
  margin-bottom:-1.6em;
}

something like

#tasks-view-filter-form .form-submit {
  margin:0;
}

would make more sense as you wouldn't have to play with the negative margin.

#3

add1sun - April 9, 2007 - 18:31
Status:active» needs review

Actually I think the only thing we need on the filter-form is this maybe this one:
#tasks-view-filter-form .form-item, #tasks-view-filter-form input {
margin-bottom:0;
}
The others really aren't necessary as far as I can see (and then the margin displays properly in FF without needing negative margins).

I've attached a patch that changes the css file to this. It displays fine for me (without extra space) on IE and FF.

AttachmentSize
tasks_remove_css.patch 573 bytes

#4

scor - June 7, 2007 - 15:25
Version:5.x-1.0» HEAD

Your patch works fine add1sun, but I think it makes more sense to have the filter button on the same line as the drop down list. patch against HEAD attached.

AttachmentSize
tasks.css_.128510.patch 605 bytes

#5

scor - June 7, 2007 - 15:29

I forgot to mention I tried my patch on FF and IE; on my own theme, blue marine and garland.

#6

scor - June 19, 2007 - 04:34
Status:needs review» fixed

fixed in HEAD.

#7

Anonymous - July 3, 2007 - 04:47
Status:fixed» closed
 
 

Drupal is a registered trademark of Dries Buytaert.